-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feature/175 social log in #183
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the next time try to give a more detail explanation in the description of the PR. Secondly, I have tried to use the social log in implementation using the last changes of develop and gives this error
Apart from that if only the google account it is going to be use in the log in, it should be taken out from the register and if it going to be use implement.
Also (even I know it is not on your task), right now the register it is not working with the changes could you have a look over it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
At first I get the same error as claudia but when clicking on "continuar con google" it does nothing and shows this error in the console:
Access to XMLHttpRequest at 'http://127.0.0.1:8000/api/auth/o/google-oauth2/?redirect_uri=http://127.0.0.1:3000/iniciar-sesion/' from origin 'http://localhost:3000' has been blocked by CORS policy:
The value of the 'Access-Control-Allow-Credentials' header in the response is '' which must be 'true' when the request's credentials mode is 'include'.
The credentials mode of requests initiated by the XMLHttpRequest is controlled by the withCredentials attribute.
Also, for log in in with google I guess that firstly there needs to be a register with google implemented.
I forgot to update the comment. You need to use 127.0.0.1 and not localhost. Also a fix in the backend is on the way. We need that fix for this to work. |
The pr is merged, use the last version of develop in the backend |
Could you please be more explicit what you have done in this pr. Have ypu fixed the log in and register or only done the social log in? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You probably are either not using last version of develop or not using 127.0.0.1 instead of localhost. I just checked and i need to push some commits that I guess didnt push and I didnt realise. I need to fix some conflicts first |
My task (and this PR) is to implement the social login. I just checked and the normal login seems to work just fine. I'm not going to check the register because its in a whole other file. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is supposed to be working if I can log in with the acount but still be redirect to the log in?. The register with Google it is also consider as an option or not? Because if not the button should not appeared on the register form.
From my opinion I think that the log in does not make much sense becuase you do not indicate the role or anything maye it is more interested in the register were you are obliged to click a role and then redirect depending to it to following steps for the register
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The social log in works in general but what I would propose it is to leave the code there done but not showing it on the screens because for our proect and the NGO comments might not be that useful
Commented out the social login button for now. After registering using social login the account must be activated providing a dni to a post /api/auth/activate/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The social log in without been commented worked for me but because of not having an account activation needed it, it does only redirect to the log in (right now this funcionality more to the side).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Doesn't seem to do anything at the moment, unsure why it's accepted since it neither takes my data from Google nor creates a new account
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I was told by Upper Management to accept this PR anyways, so here:
Added social login in with google account