-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix/146-History-Homepage #157
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think you missunderstood the Intro component. The intro component is only for displaying the background photo, the title of the page and maybe some little description. In this case, the description should be after the Intro component and before the image. Also, I don't see the utility of creating a new component here because it's some information that it's not going to be used in any other page. I would just write all the text in some
before the image and I would improve the image quality of the table and try to minimize it a bit so it does not cover the whole screen
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think the content's alright but it feels more like a timetable than anything, it's also fairly difficult to see everything because of the image's quality.
The huge text dump at the top doesn't help either.
I applied the suggested changes and some of my own, I hope it's better now! thank you |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks good and how the info it is shown but the image in the side it is a bit small.Could you make it bigger?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now, I agree with claudia maybe a bit bigger the image but so far pretty good.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Definitely looks a lot better, still a bit blurry but a lot more legible
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The image now looks bigger and it makes the screen more legible. Great job!
The History page of the homepage was missing the actual description from the real website. I added as best I could and would appreciate feedback on how it looks, thank you.