Skip to content
This repository was archived by the owner on Mar 27, 2024. It is now read-only.

Extract to tmpdir without characters that are illegal on Windows #395

Merged
merged 1 commit into from
Jul 27, 2023
Merged

Extract to tmpdir without characters that are illegal on Windows #395

merged 1 commit into from
Jul 27, 2023

Conversation

alexeagle
Copy link
Contributor

Fixes #394

@alexeagle
Copy link
Contributor Author

Note @nkubala @dlorenc this was added in #232, here's the spot 0be9c41#diff-ab967ab1a2f3a1b769106eeb7bfe892ef0e81d1d27811fa15be08e6749feee1fR263
I don't see any code review discussion about it, so I don't know if there's a reason you chose to make the TempDir have such a descriptive name. I imagine it was for debugging?

@alexeagle alexeagle changed the title make a shorter tmpdir without funny characters Extract to tmpdir without characters that are illegal on Windows Jul 21, 2023
@loosebazooka
Copy link
Member

@briandealwis maybe?

@alexeagle
Copy link
Contributor Author

Another note, even on non-Windows platforms this code frequently causes errors due to creating paths that are too long for the underlying filesystem.

@dlorenc
Copy link
Contributor

dlorenc commented Jul 23, 2023

LGTM :)

@alexeagle
Copy link
Contributor Author

@tequilarista maybe? You merged the most recent commit on HEAD

@alexeagle
Copy link
Contributor Author

@gabyx @nkubala could one of you merge this pls?

@dlorenc
Copy link
Contributor

dlorenc commented Jul 27, 2023

I think it's @loosebazooka

@loosebazooka loosebazooka merged commit 35d9770 into GoogleContainerTools:master Jul 27, 2023
@alexeagle alexeagle mentioned this pull request Jul 27, 2023
Closed
alexeagle added a commit to GoogleContainerTools/container-structure-test that referenced this pull request Jul 27, 2023
@alexeagle
chore: update container-diff dependency
7a23b58 
Picks up GoogleContainerTools/container-diff#395
fixes #183
@alexeagle alexeagle mentioned this pull request Jul 27, 2023
Merged
thesayyn pushed a commit to GoogleContainerTools/container-structure-test that referenced this pull request Jul 27, 2023
@alexeagle
chore: update container-diff dependency (#360)
8b6e083 
Picks up GoogleContainerTools/container-diff#395
fixes #183
@alexeagle alexeagle mentioned this pull request Sep 27, 2023
Merged
@chenrui333 chenrui333 mentioned this pull request Feb 22, 2024
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@loosebazooka loosebazooka loosebazooka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Windows: fails to create TempDir
3 participants
@alexeagle @loosebazooka @dlorenc