Prerendering/SSR fixes #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -31,7 +32,7 @@ | |||
| "url": "git+https://github.com/Esri/calcite-components.git" | |||
| }, | |||
| "dependencies": { | |||
| "@a11y/focus-trap": "^1.0.2", | |||
| "@a11y/focus-trap": "git+https://github.com/patrickarlt/focus-trap.git#conditional-define-build", | |||
There was a problem hiding this comment.
did you open a pr form this branch already?
There was a problem hiding this comment.
Yup. This particular branch just has the built files in it already vs the one I PR'ed andreasbm/focus-trap#1.
|
cool, this is a really neat feature, I had no idea this existed |
|
We should add a note about how to prerender these in the readme as well once it gets all sorted |
macandcheese
approved these changes
Aug 13, 2019
|
Going to merge this in, nice work @patrickarlt 👍 |
alisonailea
added a commit
that referenced
this pull request
Aug 29, 2023
feat(token-transformer): generate asset files from tokens with Style Dictionary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes a bunch of fixes to allow Calcite Components to work with Stencils prerendering system. I have a proof-of-concept of the prerendering working with Gatsby that I can share a little later.