Remove lazy #433
Merged
Remove lazy #433
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IMax153
suggested changes
Aug 15, 2022
There was a problem hiding this comment.
A few comments:
- The code should be reviewed for places where
Effect|Query.succeedwas being used to convert aLazyArgto a value. These should be removed if theLazyArgwas removed. I've tried to note these situations where I saw them. - The
orElse*,orFail*, and generally any constructors that accept an error should probably remain lazy (as we have done in thecorelibrary)
|
Thanks a lot for your comments! Helped me understood deeply why some where lazy and some non-lazy in core! |
IMax153
suggested changes
Aug 15, 2022
There was a problem hiding this comment.
No problem at all 😃
The only thing left is to make sure that the version PR will get triggered. To do that, you can run the following command:
yarn changeset
and follow the prompts in your shell. I would suggest incrementing patch versions for now, since that's what we're doing in core until v1.0.0.
Additionally, I would suggest squashing all the commits in this PR into one commit locally (after running the changesets command above). This will ensure a nice clean update to the CHANGELOG can be made.
mattiamanzati
force-pushed
the
remove-lazy
branch
from
f33afbd to
88f6af7
Compare
IMax153
approved these changes
Aug 15, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.