Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[react-lazy-load-image-component] fix onLoad props #69366

Conversation

yoonminsang
Copy link
Contributor

I modified the type incorrectly in the last pr(#66479 ). The code written in the official document is as follows.

Function called when the image has been loaded. This is the same function as the onLoad of an which contains an event object.

Select one of these and delete the others:

If changing an existing definition:

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 16, 2024

@yoonminsang Thank you for submitting this PR! I see this is your first time submitting to DefinitelyTyped 👋 — I'm the local bot who will help you through the process of getting things through.

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

Because you edited one package and updated the tests (👏), I can help you merge this PR once someone else signs off on it.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69366,
  "author": "yoonminsang",
  "headCommitOid": "794f678645fa7d5fa85abd1339e45a134f8f59eb",
  "mergeBaseOid": "9c5aeea853df366833b50a680bafd9c5413b7b16",
  "lastPushDate": "2024-04-16T07:43:57.000Z",
  "lastActivityDate": "2024-04-16T08:18:55.000Z",
  "mergeOfferDate": "2024-04-16T07:58:45.000Z",
  "mergeRequestDate": "2024-04-16T08:18:55.000Z",
  "mergeRequestUser": "yoonminsang",
  "hasMergeConflict": false,
  "isFirstContribution": true,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "react-lazy-load-image-component",
      "kind": "edit",
      "files": [
        {
          "path": "types/react-lazy-load-image-component/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/react-lazy-load-image-component/react-lazy-load-image-component-tests.tsx",
          "kind": "test"
        }
      ],
      "owners": [
        "danvk",
        "diegochavez",
        "revskill10",
        "kodai3"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "kodai3",
      "date": "2024-04-16T07:58:06.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2058448353,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added the Popular package This PR affects a popular package (as counted by NPM download counts). label Apr 16, 2024
@typescript-bot
Copy link
Contributor

🔔 @danvk @diegochavez @revskill10 @kodai3 — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

- Modify onLoad type as described in the comments
@yoonminsang yoonminsang force-pushed the react-lazy-load-image-component-onload branch from a1fd7a4 to 794f678 Compare April 16, 2024 07:50
@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner labels Apr 16, 2024
@typescript-bot
Copy link
Contributor

@yoonminsang: Everything looks good here. I am ready to merge this PR (at 794f678) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@danvk, @diegochavez, @revskill10, @kodai3: you can do this too.)

@yoonminsang
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit 69af757 into DefinitelyTyped:master Apr 16, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants