-
Notifications
You must be signed in to change notification settings - Fork 30.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[color-name] Remove myself from owners #69342
Conversation
@Ailrun Thank you for submitting this PR! This is a live comment which I will keep updated. 1 package in this PRCode ReviewsBecause this is a widely-used package, a DT maintainer will need to review it before it can be merged. You can test the changes of this PR in the Playground. Status
All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes. Diagnostic Information: What the bot saw about this PR{
"type": "info",
"now": "-",
"pr_number": 69342,
"author": "Ailrun",
"headCommitOid": "f974bb0cf96c3f8dd873b99a7d76ce559c1987aa",
"mergeBaseOid": "1a555167733e95b8be48d58af7b3b0a767caaefe",
"lastPushDate": "2024-04-12T18:26:31.000Z",
"lastActivityDate": "2024-04-14T20:11:48.000Z",
"mergeOfferDate": "2024-04-14T19:40:20.000Z",
"mergeRequestDate": "2024-04-14T20:11:48.000Z",
"mergeRequestUser": "Ailrun",
"hasMergeConflict": false,
"isFirstContribution": false,
"tooManyFiles": false,
"hugeChange": false,
"popularityLevel": "Critical",
"pkgInfo": [
{
"name": "color-name",
"kind": "edit",
"files": [
{
"path": "types/color-name/package.json",
"kind": "package-meta-ok"
}
],
"owners": [
"Ailrun"
],
"addedOwners": [],
"deletedOwners": [],
"popularityLevel": "Critical"
}
],
"reviews": [
{
"type": "approved",
"reviewer": "peterblazejewicz",
"date": "2024-04-14T19:39:40.000Z",
"isMaintainer": true
}
],
"mainBotCommentID": 2052259799,
"ciResult": "pass"
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contributions!
@Ailrun: Everything looks good here. I am ready to merge this PR (at f974bb0) on your behalf whenever you think it's ready. If you'd like that to happen, please post a comment saying:
and I'll merge this PR almost instantly. Thanks for helping out! ❤️ |
Ready to merge |
Please fill in this template.
pnpm test <package to test>
.Select one of these and delete the others:
If adding a new definition:
.d.ts
files generated via--declaration
dts-gen --dt
, not by basing it on an existing project.tsconfig.json
should havenoImplicitAny
,noImplicitThis
,strictNullChecks
, andstrictFunctionTypes
set totrue
.If changing an existing definition:
package.json
.If removing a declaration:
notNeededPackages.json
.