Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[leaflet] Forward given feature property type #69237

Conversation

someonewithpc
Copy link
Contributor

Please fill in this template.

Select one of these and delete the others:

If changing an existing definition:

  • Provide a URL to documentation or source code which provides context for the suggested changes: test using casts as a workaround
  • If this PR brings the type definitions up to date with a new version of the JS library, update the version number in the package.json.

@typescript-bot
Copy link
Contributor

typescript-bot commented Apr 1, 2024

@someonewithpc Thank you for submitting this PR!

This is a live comment which I will keep updated.

1 package in this PR

Code Reviews

This PR can be merged once it's reviewed.

You can test the changes of this PR in the Playground.

Status

  • ✅ No merge conflicts
  • ✅ Continuous integration tests have passed
  • ✅ Most recent commit is approved by type definition owners or DT maintainers

All of the items on the list are green. To merge, you need to post a comment including the string "Ready to merge" to bring in your changes.


Diagnostic Information: What the bot saw about this PR
{
  "type": "info",
  "now": "-",
  "pr_number": 69237,
  "author": "someonewithpc",
  "headCommitOid": "d8da7c4eb2e48275d529d68ccf19600ac8ffc13c",
  "mergeBaseOid": "4d2a8f9d629c339b22c772d2479b4ffb617c5cfb",
  "lastPushDate": "2024-04-01T23:17:04.000Z",
  "lastActivityDate": "2024-04-14T08:23:46.000Z",
  "maintainerBlessed": "Waiting for Code Reviews",
  "mergeOfferDate": "2024-04-14T06:29:02.000Z",
  "mergeRequestDate": "2024-04-14T08:23:46.000Z",
  "mergeRequestUser": "someonewithpc",
  "hasMergeConflict": false,
  "isFirstContribution": false,
  "tooManyFiles": false,
  "hugeChange": false,
  "popularityLevel": "Popular",
  "pkgInfo": [
    {
      "name": "leaflet",
      "kind": "edit",
      "files": [
        {
          "path": "types/leaflet/.eslintrc.json",
          "kind": "package-meta",
          "suspect": "edited"
        },
        {
          "path": "types/leaflet/index.d.ts",
          "kind": "definition"
        },
        {
          "path": "types/leaflet/leaflet-tests.ts",
          "kind": "test"
        }
      ],
      "owners": [
        "alejo90",
        "atd-schubert",
        "mcauer",
        "ronikar",
        "life777",
        "henrythasler",
        "captain-igloo",
        "someonewithpc"
      ],
      "addedOwners": [],
      "deletedOwners": [],
      "popularityLevel": "Popular"
    }
  ],
  "reviews": [
    {
      "type": "approved",
      "reviewer": "henrythasler",
      "date": "2024-04-14T06:28:21.000Z",
      "isMaintainer": false
    }
  ],
  "mainBotCommentID": 2030773962,
  "ciResult": "pass"
}

@typescript-bot typescript-bot added Popular package This PR affects a popular package (as counted by NPM download counts). Author is Owner The author of this PR is a listed owner of the package. Check Config Changes a module config files labels Apr 1, 2024
@typescript-bot
Copy link
Contributor

🔔 @alejo90 @atd-schubert @mcauer @ronikar @life777 @henrythasler @captain-igloo — please review this PR in the next few days. Be sure to explicitly select Approve or Request Changes in the GitHub UI so I know what's going on.

@typescript-bot typescript-bot added the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Apr 3, 2024
@typescript-bot
Copy link
Contributor

@someonewithpc Unfortunately, this pull request currently has a merge conflict 😥. Please update your PR branch to be up-to-date with respect to master. Have a nice day!

@someonewithpc someonewithpc force-pushed the leaflet-forward-feature-properties-type branch from f539ca1 to d8da7c4 Compare April 3, 2024 22:34
@typescript-bot typescript-bot removed the Has Merge Conflict This PR can't be merged because it has a merge conflict. The author needs to update it. label Apr 3, 2024
@typescript-bot typescript-bot added the Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. label Apr 13, 2024
@typescript-bot
Copy link
Contributor

Re-ping @alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo:

This PR has been out for over a week, yet I haven't seen any reviews.

Could someone please give it some attention? Thanks!

@henrythasler
Copy link
Contributor

@someonewithpc Can you provide a bit of context as to why this change is useful/needed?

@someonewithpc
Copy link
Contributor Author

@someonewithpc Can you provide a bit of context as to why this change is useful/needed?

It just seemed like a small improvement to me, to allow the factory function to have the same functionality as the constructor. Doesn't change much, and it's definitely not needed, but I think it's still useful

(This came up when going through #69221)

@typescript-bot typescript-bot added Owner Approved A listed owner of this package signed off on the pull request. Self Merge This PR can now be self-merged by the PR author or an owner and removed Unreviewed No one showed up to review this PR, so it'll be reviewed by a DT maintainer. labels Apr 14, 2024
@typescript-bot
Copy link
Contributor

@someonewithpc: Everything looks good here. I am ready to merge this PR (at d8da7c4) on your behalf whenever you think it's ready.

If you'd like that to happen, please post a comment saying:

Ready to merge

and I'll merge this PR almost instantly. Thanks for helping out! ❤️

(@alejo90, @atd-schubert, @mcauer, @ronikar, @life777, @henrythasler, @captain-igloo: you can do this too.)

@someonewithpc
Copy link
Contributor Author

Ready to merge

@typescript-bot typescript-bot merged commit be8f915 into DefinitelyTyped:master Apr 14, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Author is Owner The author of this PR is a listed owner of the package. Check Config Changes a module config files Owner Approved A listed owner of this package signed off on the pull request. Popular package This PR affects a popular package (as counted by NPM download counts). Self Merge This PR can now be self-merged by the PR author or an owner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants