Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO-TICKET] Add Rack integration tests with deny/pass list #4536

Merged
merged 1 commit into from
Mar 25, 2025

Conversation

Strech
Copy link
Member

@Strech Strech commented Mar 25, 2025

What does this PR do?

Adds fast running integration tests for Rack with deny/pass list and blocking

Motivation:

We have more intensive tests, but they are very slow and not well maintained and hopefully we could deprecate some of them soon

Change log entry

No.

Additional Notes:

No.

How to test the change?

CI.

@github-actions github-actions bot added the dev/testing Involves testing processes (e.g. RSpec) label Mar 25, 2025
@Strech Strech force-pushed the add-passlist-and-denylist-integration-rack-tests branch from 82ce6c8 to 5f6001b Compare March 25, 2025 13:38
@Strech Strech marked this pull request as ready for review March 25, 2025 13:38
@Strech Strech requested a review from a team as a code owner March 25, 2025 13:38
@Strech Strech added the appsec Application Security monitoring product label Mar 25, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 25, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.75%. Comparing base (39172da) to head (7dc9766).
Report is 3 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #4536      +/-   ##
==========================================
- Coverage   97.76%   97.75%   -0.01%     
==========================================
  Files        1390     1391       +1     
  Lines       84760    84821      +61     
  Branches     4281     4281              
==========================================
+ Hits        82862    82917      +55     
- Misses       1898     1904       +6     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@datadog-datadog-prod-us1
Copy link
Contributor

datadog-datadog-prod-us1 bot commented Mar 25, 2025

Datadog Report

Branch report: add-passlist-and-denylist-integration-rack-tests
Commit report: 7dc9766
Test service: dd-trace-rb

✅ 0 Failed, 20845 Passed, 1370 Skipped, 3m 26.92s Total Time

@pr-commenter
Copy link

pr-commenter bot commented Mar 25, 2025

Benchmarks

Benchmark execution time: 2025-03-25 15:23:12

Comparing candidate commit 7dc9766 in PR branch add-passlist-and-denylist-integration-rack-tests with baseline commit 39172da in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics.

@Strech Strech force-pushed the add-passlist-and-denylist-integration-rack-tests branch from 5f6001b to 7dc9766 Compare March 25, 2025 14:59
@Strech Strech enabled auto-merge March 25, 2025 15:04
@Strech Strech merged commit 849baad into master Mar 25, 2025
255 checks passed
@Strech Strech deleted the add-passlist-and-denylist-integration-rack-tests branch March 25, 2025 15:26
@github-actions github-actions bot added this to the 2.13.0 milestone Mar 25, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
appsec Application Security monitoring product dev/testing Involves testing processes (e.g. RSpec)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants