-
Notifications
You must be signed in to change notification settings - Fork 384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[NO-TICKET] Add Rack integration tests with deny/pass list #4536
[NO-TICKET] Add Rack integration tests with deny/pass list #4536
Conversation
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
82ce6c8
to
5f6001b
Compare
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
spec/datadog/appsec/contrib/integration/rack/blocking_with_deny_and_pass_list_spec.rb
Show resolved
Hide resolved
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #4536 +/- ##
==========================================
- Coverage 97.76% 97.75% -0.01%
==========================================
Files 1390 1391 +1
Lines 84760 84821 +61
Branches 4281 4281
==========================================
+ Hits 82862 82917 +55
- Misses 1898 1904 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Datadog ReportBranch report: ✅ 0 Failed, 20845 Passed, 1370 Skipped, 3m 26.92s Total Time |
BenchmarksBenchmark execution time: 2025-03-25 15:23:12 Comparing candidate commit 7dc9766 in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 31 metrics, 2 unstable metrics. |
5f6001b
to
7dc9766
Compare
What does this PR do?
Adds fast running integration tests for Rack with deny/pass list and blocking
Motivation:
We have more intensive tests, but they are very slow and not well maintained and hopefully we could deprecate some of them soon
Change log entry
No.
Additional Notes:
No.
How to test the change?
CI.