[RUM-8908] SR: Fixed Android build issue for RN <= 0.68 #819
+111
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Datadog ReportBranch report: ✅ 0 Failed, 651 Passed, 1 Skipped, 12.35s Total Time |
marco-saia-datadog
force-pushed
the
marcosaia/RUM-8908/fix-sr-android-build
branch
from
1d36c99 to
e6eecb4
Compare
sbarrio
reviewed
Mar 12, 2025
.../rn69/kotlin/com.datadog.reactnative.sessionreplay/utils/ReactViewBackgroundDrawableUtils.kt
Show resolved
Hide resolved
sbarrio
previously approved these changes
Mar 12, 2025
0xnm
reviewed
Mar 13, 2025
Comment on lines
+73
to
+81
| val borderRgb = reflectionUtils.getDeclaredField( | ||
| backgroundDrawable, | ||
| BORDER_RGB_FIELD_NAME | ||
| ) as Spacing? | ||
|
|
||
| val borderAlpha = reflectionUtils.getDeclaredField( | ||
| backgroundDrawable, | ||
| BORDER_ALPHA_FIELD_NAME | ||
| ) as Spacing? |
There was a problem hiding this comment.
Suggested change
| val borderRgb = reflectionUtils.getDeclaredField( | |
| backgroundDrawable, | |
| BORDER_RGB_FIELD_NAME | |
| ) as Spacing? | |
| val borderAlpha = reflectionUtils.getDeclaredField( | |
| backgroundDrawable, | |
| BORDER_ALPHA_FIELD_NAME | |
| ) as Spacing? | |
| val borderRgb = reflectionUtils.getDeclaredField( | |
| backgroundDrawable, | |
| BORDER_RGB_FIELD_NAME | |
| ) as? Spacing | |
| val borderAlpha = reflectionUtils.getDeclaredField( | |
| backgroundDrawable, | |
| BORDER_ALPHA_FIELD_NAME | |
| ) as? Spacing |
| return reflectionUtils.getDeclaredField( | ||
| backgroundDrawable, | ||
| COLOR_FIELD_NAME | ||
| ) as Int? |
There was a problem hiding this comment.
Suggested change
| ) as Int? | |
| ) as? Int |
marco-saia-datadog
force-pushed
the
marcosaia/RUM-8908/fix-sr-android-build
branch
from
95556de to
7a08174
Compare
0xnm
previously approved these changes
Mar 13, 2025
sbarrio
previously approved these changes
Mar 13, 2025
marco-saia-datadog
force-pushed
the
marcosaia/RUM-8908/fix-sr-android-build
branch
from
7a08174 to
e6eecb4
Compare
cdn34dd
approved these changes
Mar 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes a Session Replay Android build error that occurs for RN <= 0.68.
The issue is caused by
ReactViewBackgroundDrawablemethodgetBorderColorbeing private prior to RN 0.69. In order to fix it we leverage reflection to access the private attributes and resolve the border color on our side.Review checklist (to be filled by reviewers)