Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix IsZero bug in std/math/emulated/field_assert.go #1002

Merged

Conversation

readygo67
Copy link
Contributor

@readygo67 readygo67 commented Jan 15, 2024

Description

Fix the IsZero() bug in std/math/emulated/field_assert.go

Fixes # (issue)
#980

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How has this been tested?

zero and Non-zero tests have been implemented in field_assert_test.go

How has this been benchmarked?

No benchmark has been done

Checklist:

  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have added tests that prove my fix is effective or that my feature works
  • I did not modify files generated from templates
  • golangci-lint does not output errors locally
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

@CLAassistant
Copy link

CLAassistant commented Jan 15, 2024

CLA assistant check
All committers have signed the CLA.

@ivokub ivokub self-requested a review January 15, 2024 12:19
Copy link
Collaborator

@ivokub ivokub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is a perfect contribution. Thank you for reporting the issue and contributing a patch!

@ivokub ivokub merged commit 34fdb03 into Consensys:master Jan 15, 2024
@readygo67 readygo67 deleted the fix/std_math_emulated_fieldassert_IsZero branch March 6, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants