Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: PlonK frontend should use constraint/ package #467

Closed
gbotrel opened this issue Feb 8, 2023 · 0 comments · Fixed by #493
Closed

refactor: PlonK frontend should use constraint/ package #467

gbotrel opened this issue Feb 8, 2023 · 0 comments · Fixed by #493
Assignees
@gbotrel
Labels
cleanup perf zk-evm
Milestone
v0.9.0

Comments

@gbotrel
Copy link
Collaborator

gbotrel commented Feb 8, 2023

No description provided.

@gbotrel gbotrel added this to the v0.9.0 milestone Feb 8, 2023
@gbotrel gbotrel self-assigned this Feb 8, 2023
@gbotrel gbotrel linked a pull request Feb 24, 2023 that will close this issue
refactor: plonk uses constraint/ and couple of fixes closes #467 #493
Merged
gbotrel added a commit that referenced this issue Feb 28, 2023
@gbotrel @ivokub
refactor: plonk uses constraint/ and couple of fixes closes #467 (#493)
4f9bfba 
* refactor: remove API wrapper in test engine

This was used to create API for field emulation. But we removed the fake-API
interface in favor of dedicated emulated field type.

* feat: add defer to compiler

* fix: stop collecting traces on deferred fns

* fix: make internal key type private

* refactor: step 1 use constraint/ simplify addPlonkConstraint a bit

* refactor,perf: scs.Add(v,v,c) is better

* fix: fix some scs API that incorrectly discarded boolean coeffs

* style: code cleaning

* fix: missing return

* fix: panic when inverse by constant 0 in plonk

---------

Co-authored-by: Ivo Kubjas <ivo.kubjas@consensys.net>
@gbotrel gbotrel closed this as completed Mar 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gbotrel gbotrel

Labels
cleanup perf zk-evm
Projects
None yet
Milestone
v0.9.0
Development

Successfully merging a pull request may close this issue.

refactor: plonk uses constraint/ and couple of fixes closes #467 Consensys/gnark
1 participant
@gbotrel