Simplify ES Docker configuration #19
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandertan
force-pushed
the
simplify-es-conf
branch
from
8c2c642 to
4d52d23
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi CogStack team, a few months I suggested to use a
.env-file for configuring OpenSearch/ElasticSearch, but that was before I understood the potential of the OpenSearch-provided YML file, in this caseelasticsearch_opensearch.yml. It's pretty well documented how the security properties can fit in the YML file: https://opensearch.org/docs/latest/opensearch/install/docker-security/ . With only a few ENV vars in the documented example's docker-compose, I'm not sure having a seperate.envfor that is too much added complexity.I've also updated the documentation in which I corrected some information on how to use the env variable
COMPOSE_PROJECT_NAME.