Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix instance scales #10808

Merged
merged 2 commits into from
Sep 22, 2022
Merged

Fix instance scales #10808

merged 2 commits into from
Sep 22, 2022

Conversation

lilleyse
Copy link
Contributor

Fixes #10807

@cesium-concierge
Copy link

Thanks for the pull request @lilleyse!

  • ✔️ Signed CLA found.
  • CHANGES.md was not updated.
    • If this change updates the public API in any way, please add a bullet point to CHANGES.md.
  • ❔ Unit tests were not updated.
    • Make sure you've updated tests to reflect your changes, added tests for any new code, and ran the code coverage tool.

Reviewers, don't forget to make sure that:

  • Cesium Viewer works.
  • Works in 2D/CV.

Copy link
Contributor

@sanjeetsuhag sanjeetsuhag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Both InstancedScale and InstancedScaleNonUniform sample tilesets also have rotation so I can't test this directly, but looking at the example in the issue, I think this should suffice. Thanks @lilleyse!

@sanjeetsuhag sanjeetsuhag merged commit af9af42 into main Sep 22, 2022
@sanjeetsuhag sanjeetsuhag deleted the fix-scale branch September 22, 2022 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

when i3dm tile without rotation property,the scale will be incorrectory(V1.97)
3 participants