Set enableModelExperimental = false by default + change Model.boundingSphere
#10589
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the pull request @j9liu!
Reviewers, don't forget to make sure that:
|
added 2 commits
July 22, 2022 15:24
j9liu
force-pushed
the
model-experimental-false-by-default
branch
from
990f870 to
a92bb5e
Compare
|
@ptrgags updated -- I forgot to change the version numbers in the deprecation warnings in |
|
@j9liu updates look good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We're pushing back the
ModelExperimental -> Modelchange to September, so we're disabling this flag before the Cesium 1.96 release.It was also easier to change the behavior of
Model.boundingSpherein this PR, since some unit tests were changed to account forModelExperimental's behavior. This had been marked to be deprecated in 1.96 already so this shouldn't come as a surprise.Finally, we neglected to deprecate the CPU instancing in
ModelInstanceCollectionearlier, so that has been noted inCHANGES.md.