-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add memory statistics for the global ResourceCache
#10413
Conversation
Thanks for the pull request @ptrgags!
Reviewers, don't forget to make sure that:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptrgags did a first pass and left some comments!
Just leaving another Sandcastle link for testing property tables in the inspector, still have to fix the missing unit tests |
@j9liu updated! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ptrgags -- did another pass. The biggest glaring issue is that the dropdown in the inspector isn't formatted well... maybe something additional needs to be modified in the HTML?
Also this PR should get logged in CHANGES.md
.
Source/Widgets/Cesium3DTilesInspector/Cesium3DTilesInspectorViewModel.js
Outdated
Show resolved
Hide resolved
Source/Widgets/Cesium3DTilesInspector/Cesium3DTilesInspectorViewModel.js
Show resolved
Hide resolved
Source/Widgets/Cesium3DTilesInspector/Cesium3DTilesInspectorViewModel.js
Show resolved
Hide resolved
@j9liu updated! |
@ptrgags you missed one of my comments; there's a unit test in EDIT: also |
@j9liu while trying to fix the broken test, I learned that the metadata buffer views are copied and unloaded from the cache. The overall |
@j9liu updated! |
@ptrgags - I just fixed a typo in the changelog, otherwise this looks good. I'll wait on Travis to pass before I merge. |
Part of #9886, this PR tracks memory usage in the global
ResourceCache
used to load resources forModelExperimental
. It is the global counterpart to #10397 which tracks memory on a per-ModelExperimental
basis.Some important caveats:
ModelExperimental
may use a mix of resources loaded from the cache, and additional buffers generated at runtime as needed. Determining the size of the overlap is non-trivial.Sandcastle for testing -- In the
Logging
section of the inspector, toggle on the newResourceCacheStatistics
like so:@j9liu could you review?
CC @lilleyse