-
Notifications
You must be signed in to change notification settings - Fork 654
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature(wren-ui): add planning stage #1222
Conversation
WalkthroughThis pull request introduces a new Changes
Sequence DiagramsequenceDiagram
participant User
participant UI
participant AskingTask
User->>UI: Initiate Task
UI->>AskingTask: Set Status to PLANNING
AskingTask-->>UI: Update Task State
UI->>UI: Render Planning State
Possibly related PRs
Suggested labels
Poem
✨ Finishing Touches
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
wren-ui/src/components/pages/home/prompt/Result.tsx (1)
153-153
: Ensure consistent user messaging for the new “Planning” state.While "Organizing thoughts" nicely captures the planning concept, consider using language that aligns more closely with adjacent states such as "Understanding question" or "Searching data" for consistency and clarity.
wren-ui/src/apollo/server/schema.ts (1)
539-539
: Add test coverage for new AskingTaskStatus PLANNING.Introducing a new enum member requires ensuring it’s accurately handled in resolvers and tested in queries/mutations. Make sure server-side logic and integration tests account for the new
PLANNING
status flow.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (7)
wren-ui/src/apollo/client/graphql/__types__.ts
(1 hunks)wren-ui/src/apollo/server/models/adaptor.ts
(1 hunks)wren-ui/src/apollo/server/schema.ts
(1 hunks)wren-ui/src/components/pages/home/prompt/Result.tsx
(2 hunks)wren-ui/src/components/pages/home/prompt/index.tsx
(1 hunks)wren-ui/src/hooks/useAskProcessState.tsx
(1 hunks)wren-ui/src/utils/enum/home.ts
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (3)
- GitHub Check: Analyze (python)
- GitHub Check: Analyze (javascript-typescript)
- GitHub Check: Analyze (go)
🔇 Additional comments (5)
wren-ui/src/hooks/useAskProcessState.tsx (1)
7-7
: Good inclusion ofPROCESS_STATE.PLANNING
ingetIsProcessing
.
This ensures that the planning phase is now correctly recognized as an active process.wren-ui/src/apollo/server/models/adaptor.ts (1)
74-74
: Enum extension withPLANNING
looks appropriate.
This addition offers a clearer representation of the planning stage in the overall ask workflow.wren-ui/src/components/pages/home/prompt/index.tsx (1)
64-64
: Well-integrated mapping ofAskingTaskStatus.PLANNING
toPROCESS_STATE.PLANNING
.
This maintains consistency across the system and ensures the UI can fully manage the new planning phase.wren-ui/src/components/pages/home/prompt/Result.tsx (1)
273-273
: Confirm that the PLANNING state is properly integrated in all relevant components.Adding
PROCESS_STATE.PLANNING
here is a good expansion, but verify downstream references (like logs, analytics, or any relevant place where states are tracked) to ensure no missing references.✅ Verification successful
PLANNING state is properly integrated across all components ✅
The state is consistently implemented across GraphQL schema, state management, and UI components with proper mappings and transitions.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
#!/bin/bash # Description: Search for references to PLANNING usage to confirm consistent handling across the codebase rg -A3 "PLANNING"Length of output: 2078
wren-ui/src/apollo/client/graphql/__types__.ts (1)
45-45
: Enum extension looks correct.The addition of
PLANNING
aligns with other states. No immediate issues found.
Description
Add planning stage to asking flow
Summary by CodeRabbit
New Features
Improvements