Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(wren-ai-service): improve ai service #1068

Merged
merged 8 commits into from
Dec 27, 2024
Merged

chore(wren-ai-service): improve ai service #1068

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
fa90965
return empty schema if no sample data for chart
cyyeh Dec 26, 2024
8098452
add script to test sql
cyyeh Dec 26, 2024
636831f
refine ui
cyyeh Dec 26, 2024
6f0cd4a
update
cyyeh Dec 26, 2024
33617e6
update
cyyeh Dec 26, 2024
48a2839
rename
cyyeh Dec 26, 2024
b4e2dc1
fix typo
cyyeh Dec 27, 2024
b609b0a
fix typo
cyyeh Dec 27, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
rename
  • Loading branch information
@cyyeh
cyyeh committed Dec 26, 2024
commit 48a28391b248c1caa7d49bf80dfe6d36d2b27953
2 changes: 1 addition & 1 deletion wren-ai-service/Justfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,4 +68,4 @@ use-wren-ui-as-engine:
poetry run python -m src.force_update_config

run-sql mdl_path="" data_source="" sameple_dataset="":
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Typo in parameter name
The parameter is spelled sameple_dataset, instead of sample_dataset. This might cause confusion or errors when referencing the variable.

-run-sql mdl_path="" data_source="" sameple_dataset="":
+run-sql mdl_path="" data_source="" sample_dataset="":
📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
run-sql mdl_path="" data_source="" sameple_dataset="":
run-sql mdl_path="" data_source="" sample_dataset="":

poetry run python demo/test_sql.py --mdl-path "{{mdl_path}}" --data-source "{{data_source}}" --sample-dataset "{{sameple_dataset}}"
poetry run python demo/run_sql.py --mdl-path "{{mdl_path}}" --data-source "{{data_source}}" --sample-dataset "{{sameple_dataset}}"
0 wren-ai-service/demo/test_sql.py → wren-ai-service/demo/run_sql.py
View file
Open in desktop
File renamed without changes.
Loading