Skip to content

Fix Ecdsa.testBias #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Fix Ecdsa.testBias #57

wants to merge 1 commit into from

Conversation

francescomari
Copy link

@francescomari francescomari commented Jun 21, 2018

Fix the way Ecdsa.testBias iterates over the signature logic. Simplify the aggregation of the test results.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@francescomari francescomari changed the title Fix Ecdsa.generateKey Fix Ecdsa.testBias Jun 21, 2018
@francescomari
Copy link
Author

I signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

thaidn added a commit that referenced this pull request Dec 17, 2019
While I'm here, fix a bunch of Lint errors.

NOKEYCHECK=True
PiperOrigin-RevId: 286042650
GitOrigin-RevId: d644e50fa0b8246d679f1e5b6daa32a76a130ebf
@thaidn
Copy link
Contributor

thaidn commented Dec 17, 2019

This was merged in d8ed1ba.

GitHub should show you as the author of the commit, but somehow the authoring information was lost when I copied the change from our internal repo. I'm so sorry, but I don't know how to fix this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants