Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TalonFX Fix #18

Merged
merged 35 commits into from
Feb 17, 2023
Merged

TalonFX Fix #18

merged 35 commits into from
Feb 17, 2023

Conversation

thenetworkgrinch
Copy link
Contributor

A functional TalonFX Swerve Motor Interface for YAGSL.

7910f6ba7ee4 and others added 21 commits February 14, 2023 20:57
@7910f6ba7ee4
add placeIn0To360
434cad1
@7910f6ba7ee4
revise getposition
65bebb8
@7910f6ba7ee4
fix scope to use true position
14d320d
@7910f6ba7ee4
fix get position for drive motor
4dce607
@7910f6ba7ee4
actually fix get position for drive motor
818a6f1
@7910f6ba7ee4
add documentation and move function
ad5fd51
@7910f6ba7ee4
add description inside of placeInAppropriate0To360Scope
cf7d052
@7910f6ba7ee4
change formatting to match project
8d110ec
@thenetworkgrinch
Somewhat working. Adjusted angles are incorrect.
c185f0b 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Attempt to adjust falcon's using configs.
a270391 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Ensure 0 to 360 is within the range of 0 to 360. Added simulation.
53d8e09 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Adjusted current point by removing coefficient.
9da0bb2 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Removed support for integrating the absolute encoder with talon fx.
a165325 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Removed sensor coefficient in favor of manually adjusting everything.
45bd89c 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Removed sensor coefficient and added conversion function.
3bf567c 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Fixed physicalproperties.json to represent falcon encoder.
776c2ff 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Updated freespeed rpm to reflect falcon free speeds.
3016c40 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Merge branch 'talonfx' into patch-talon-wrapping
fbd6c30
@thenetworkgrinch
Added more documentation.
7af722d 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Reformatted code.
e49b847 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Added documentation.
4010410 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch thenetworkgrinch added the bug Something isn't working label Feb 16, 2023
@thenetworkgrinch thenetworkgrinch self-assigned this Feb 16, 2023
@thenetworkgrinch
Add angle normalization for readings and setting. Attempted simulation.
d534810 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Fixed calculation of degrees per second since getSensorVelocity is in…
0abd30f 
… 100ms.

Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Rounded output valus to reduce confusion.
e8f00f4 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch thenetworkgrinch linked an issue Feb 16, 2023 that may be closed by this pull request
Fix Falcon Angle motor closed loop PID #17
Closed
thenetworkgrinch and others added 3 commits February 16, 2023 20:17
@thenetworkgrinch
Merge pull request #14 from 7910f6ba7ee4/patch-talon-wrapping
43605cd 
Fix for TalonFX PID wrapping
@thenetworkgrinch
Removed unnecessary comments.
5cb62dd 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Added credits to Team 1466. Updated a method to run swerve without ab…
a0e0234 
…solute encoders.

Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Moved falcon configurations into folder "falcon". Added back neo exam…
368c34e 
…ple configuration. Removed angle reporting in simulation. Reformatted code.

Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch thenetworkgrinch marked this pull request as ready for review February 17, 2023 03:04
@thenetworkgrinch
Changed team number back to 3481.
104a14e 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch
Removed commented out code. Updated SwerveMotor documentation.
4c0edc1 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch thenetworkgrinch merged commit 1337b87 into main Feb 17, 2023
@thenetworkgrinch thenetworkgrinch deleted the talonfx branch February 17, 2023 04:36
thenetworkgrinch pushed a commit that referenced this pull request Oct 4, 2024
@clrozeboom
Merge pull request #18 from BroncBotz3481/dev
40bf200 
Dev - Update to latest
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thenetworkgrinch thenetworkgrinch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix Falcon Angle motor closed loop PID
2 participants
@thenetworkgrinch @7910f6ba7ee4