-
Notifications
You must be signed in to change notification settings - Fork 222
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement NetworkAlerts #136
Conversation
I'm un-drafting this. |
I like these changes but I am hesitant to force users to use AdvantageScope (even though it is great!) Does this fallback to reporting via |
I'd be worried if the |
It does indeed! It actually prints to the DriverStation even if the plugin isn't used. |
When it's activated, updating the text re-prints it and sends the updated text to the network table. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it looks great!
@TheGamer1002 This merge may be removed in the future. Upon further testing the memory allocation of the |
Oh jeez, that is... a LOT of memory. If you want to remove it as a temporary fix, I can see what can be done about this, but this should definitely not be happening. |
@TheGamer1002 I will remove it right before week 0 comp if you don't submit a patch by then. |
I think I fixed it, see the YAGSL PR |
See here