Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement NetworkAlerts #136

Merged
merged 2 commits into from
Jan 17, 2024
Merged

Implement NetworkAlerts #136

merged 2 commits into from
Jan 17, 2024

Conversation

TheGamer1002
Copy link
Contributor

See here

@TheGamer1002
Copy link
Contributor Author

I'm un-drafting this.

@TheGamer1002 TheGamer1002 marked this pull request as ready for review January 16, 2024 22:00
@thenetworkgrinch
Copy link
Contributor

I like these changes but I am hesitant to force users to use AdvantageScope (even though it is great!) Does this fallback to reporting via DriverStation?

@thenetworkgrinch
Copy link
Contributor

I'd be worried if the setText function isnt used when the alert is activated.

@TheGamer1002
Copy link
Contributor Author

I like these changes but I am hesitant to force users to use AdvantageScope (even though it is great!) Does this fallback to reporting via DriverStation?

It does indeed! It actually prints to the DriverStation even if the plugin isn't used.

@TheGamer1002
Copy link
Contributor Author

I'd be worried if the setText function isnt used when the alert is activated.

When it's activated, updating the text re-prints it and sends the updated text to the network table.

Copy link
Collaborator

@Technologyman00 Technologyman00 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it looks great!

@thenetworkgrinch thenetworkgrinch merged commit 7ad0c77 into BroncBotz3481:main Jan 17, 2024
TheGamer1002 added a commit to TheGamer1002/YAGSL that referenced this pull request Jan 17, 2024
@thenetworkgrinch
Copy link
Contributor

thenetworkgrinch commented Feb 7, 2024

@TheGamer1002 This merge may be removed in the future. Upon further testing the memory allocation of the Alert class is absolutely insane (greater than 50% of all YAGSL utilization right now). If you would like to save it, you may want to optimize it.

@thenetworkgrinch
Copy link
Contributor

de6344f993c3b2aac9c9cbe6d1ad4efaa950681c.png

@TheGamer1002
Copy link
Contributor Author

Oh jeez, that is... a LOT of memory. If you want to remove it as a temporary fix, I can see what can be done about this, but this should definitely not be happening.

@thenetworkgrinch
Copy link
Contributor

@TheGamer1002 I will remove it right before week 0 comp if you don't submit a patch by then.

@TheGamer1002
Copy link
Contributor Author

I think I fixed it, see the YAGSL PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants