Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gyro Roll and Gyro Rotation3d get methods #13

Merged
merged 5 commits into from
Feb 15, 2023

Conversation

7910f6ba7ee4
Copy link
Contributor

  • fix documentation
  • create method for getting roll
  • if robot is not real, return empty Rotation2d for roll and pitch. In the future, perhaps this could also use an accumulator according to a 3d environment, but that would require a lot of work, so this is good for now.
  • add method for getting a rotation3d of the gyro. Instead of creating it with the already existing yaw/pitch/roll methods, creates it anew from the radians reported by gyro. This only creates one call to the imu, whereas creating it with existing methods would create three calls. I'm not sure how significant this is for performance, but it seems alright.

Copy link
Contributor

@thenetworkgrinch thenetworkgrinch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like this. I completely forgot about Rotation3d for this.

@thenetworkgrinch thenetworkgrinch merged commit 0b06e82 into BroncBotz3481:main Feb 15, 2023
@7910f6ba7ee4 7910f6ba7ee4 deleted the patch-gyro-angle branch February 15, 2023 02:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants