Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LockPose not working. #51

Closed
7910f6ba7ee4 opened this issue Mar 9, 2023 · 1 comment · Fixed by #54
Closed

LockPose not working. #51

7910f6ba7ee4 opened this issue Mar 9, 2023 · 1 comment · Fixed by #54
Assignees
@thenetworkgrinch
Labels
bug Something isn't working

Comments

@7910f6ba7ee4
Copy link
Contributor

7910f6ba7ee4 commented Mar 9, 2023 •
edited
Loading

The lockPose() method does not work because it commands module states that have a speed of 0. In the setModuleStates() method, there are a few lines put into place to stop angle movement when speeds are less than 0.1.

Since the lines that stop module angular movement are useful in stopping excessive module movement in place, the lockPose() function should probably be updated, possibly using an overload with setModuleStates().

https://github.com/BroncBotz3481/YAGSL-Example/tree/51-lockpose-not-working is the linked branch for the issue.
@7910f6ba7ee4 7910f6ba7ee4 added the bug Something isn't working label Mar 9, 2023
@thenetworkgrinch
Copy link
Contributor

i can do this change later today when i add resetEncoders if you want. Its the exact same idea as you suggested.

@thenetworkgrinch thenetworkgrinch self-assigned this Mar 9, 2023
thenetworkgrinch added a commit that referenced this issue Mar 9, 2023
@thenetworkgrinch
Address issue #51 and BroncBotz3481/YAGSL#9
2af7289 
Signed-off-by: thenetworkgrinch <thenetworkgrinch@users.noreply.github.com>
@thenetworkgrinch thenetworkgrinch linked a pull request Mar 9, 2023 that will close this issue
Address issue #51 and YAGSL/issues/9 #54
Merged
thenetworkgrinch added a commit that referenced this issue Mar 9, 2023
@thenetworkgrinch
Merge pull request #54 from BroncBotz3481/51-lockpose-not-working
e8dc97b 
Address issue #51 and YAGSL/issues/9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@thenetworkgrinch thenetworkgrinch

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Address issue #51 and YAGSL/issues/9 BroncBotz3481/YAGSL-Example
2 participants
@thenetworkgrinch @7910f6ba7ee4