Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updates to Google Maps API response handling and field requirements #8

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mkokes
Copy link

@mkokes mkokes commented Aug 7, 2019

I made some changes to how the Google Maps API response is handled and set the ability to match up multiple fields when Google Maps is set to be the geocoder.

Copy link
Contributor

@andrewminion-luminfire andrewminion-luminfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you update the readme changelog with v0.0.3 changes? Looks like you removed v0.0.2—not sure if that was intentional or not.

@mkokes
Copy link
Author

mkokes commented Aug 7, 2019

Sorry about that I was a little confused, I added the missing info back into the readme and added 0.0.3 info to the changelog along with some url updates

Copy link
Contributor

@andrewminion-luminfire andrewminion-luminfire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Without having tested it, the code changes look good. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants