Add armory support for private Github APIs #1162
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
You have successfully added a new CodeQL configuration |
|
We'll get this merged shortly, been traveling recently for work. |
moloch--
approved these changes
Mar 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main purpose of the PR is to make it possible to specify authorization/credentials in conjunction with using a private Github based armory, using the existing
armories.jsonconfig file. There is also some code clean-up to consolidate the http request functionality.NB. as part of the change, both the API-based index and package parsers have been switched to use the API Github file download endpoint, instead of the browser based one (
asset.BrowserDownloadURL->asset.URL), so that we can optionally use an Authorization header.