-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tauhid621/test initiative #17
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajinkya599
approved these changes
Jan 21, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left some comments.
Note to port the changes to main
as well.
src/report/reportGenerator.ts
Outdated
row.push(cve[KEY_POLICY_DEF_ID]); | ||
|
||
if (cve[KEY_POLICY_SET_ID]) { | ||
row.push(`${cve[KEY_POLICY_SET_ID]} : ${cve[KEY_POLICY_DEF_ID]}`); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this closed with the PM?
tauhid621
added a commit
that referenced
this pull request
Feb 10, 2021
initiative data in definition field (cherry picked from commit 0bc671c)
tauhid621
added a commit
that referenced
this pull request
Feb 11, 2021
Josh-01
added a commit
that referenced
this pull request
Jul 28, 2021
* Removing \ * Updating name to Azure Policy Compliance Scan * Updating link to action.yml to main * Updating to releases/v0 changes * Updated login action version (#7) * Actions core update to 1.2.6 (#11) * Bump lodash from 4.17.15 to 4.17.20 (#13) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.15 to 4.17.20. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.15...4.17.20) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Tauhid621/test initiative (#17) (#19) initiative data in definition field (cherry picked from commit 0bc671c) * Adding support for sovereign cloud (#15) (#18) * Support for soverign cloud added * Error printed * await added * tests fixed * PR comments resolved (cherry picked from commit 72c860a) * Added example for resource level scan (#8) * Added trigger for L2 tests. (#23) * Bump lodash from 4.17.20 to 4.17.21 (#27) Bumps [lodash](https://github.com/lodash/lodash) from 4.17.20 to 4.17.21. - [Release notes](https://github.com/lodash/lodash/releases) - [Commits](lodash/lodash@4.17.20...4.17.21) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump hosted-git-info from 2.8.8 to 2.8.9 (#26) Bumps [hosted-git-info](https://github.com/npm/hosted-git-info) from 2.8.8 to 2.8.9. - [Release notes](https://github.com/npm/hosted-git-info/releases) - [Changelog](https://github.com/npm/hosted-git-info/blob/v2.8.9/CHANGELOG.md) - [Commits](npm/hosted-git-info@v2.8.8...v2.8.9) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Bump y18n from 4.0.0 to 4.0.1 (#25) Bumps [y18n](https://github.com/yargs/y18n) from 4.0.0 to 4.0.1. - [Release notes](https://github.com/yargs/y18n/releases) - [Changelog](https://github.com/yargs/y18n/blob/master/CHANGELOG.md) - [Commits](https://github.com/yargs/y18n/commits) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Updated Readme for policy compliance scan actions (#16) * Update README.md * Update README.md Co-authored-by: Usha N <n-usha@github.com> * Bump ws from 7.3.1 to 7.4.6 (#30) Bumps [ws](https://github.com/websockets/ws) from 7.3.1 to 7.4.6. - [Release notes](https://github.com/websockets/ws/releases) - [Commits](websockets/ws@7.3.1...7.4.6) Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update issue templates * HealthDashboard Onboarding workflows (#33) * Create labels.yml * Create add-labels.yml * Create defaultLabels.yml * Update add-labels.yml * Cleanup (#34) * Delete .github/config directory * Delete add-labels.yml * Added changes for fork PR approval (#35) * Update integration-tests.yml * Update integration-tests.yml * Update integration-tests.yml * Fork PR L2 error fix (#36) * Fork PR L2 error fix * Update TriggerIntegrationTests.sh * Fork repo pr bug fix (#37) * Fork PR L2 error fix * Update TriggerIntegrationTests.sh * Update TriggerIntegrationTests.sh * feat: add support for ignoring policies (#21) Co-authored-by: Jyotsna <Josh-01@github.com> Co-authored-by: rgsubh <64013610+rgsubh@users.noreply.github.com> Co-authored-by: Raiyan <raiyanalam@yahoo.com> Co-authored-by: Deepak Sattiraju <desattir@microsoft.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Tauhid Anjum <tauhidanjum@gmail.com> Co-authored-by: Ajinkya <11447401+ajinkya599@users.noreply.github.com> Co-authored-by: Sundar <sundargs2000@github.com> Co-authored-by: Zainudeen V K <zainuvk@github.com> Co-authored-by: Usha N <n-usha@github.com> Co-authored-by: Antoine <Tailzip@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : Initiative results were not distinguishable from definition results.#10
Fix : UI table - Show 'definition id \n (initiative id)' instead of just definition_id.
For csv file. Add another column 'INITIATIVE_ID'.
Note : we are not having another column in UI table as this will cause rows to overflow.
![Screenshot 2021-01-21 at 3 17 32 PM](/https://user-images.githubusercontent.com/17411453/105343190-4f4e7380-5c07-11eb-8d58-dcb4b753bb51.png)