-
Notifications
You must be signed in to change notification settings - Fork 566
Conversation
Can one of the admins verify this patch? |
@ramya-rao-a Can you help review my PR, Thanks. I have an email thread discuss about the background. |
@joheredi Please review the changes here on updating the version of xml builder package being used |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change looks good and all tests seem to be passing
v0.9.23 published to NPM an hour ago introduces: Cannot find module 'xmlbuilder/lib/XMLBuilder' |
Can you point out to me Where do you get this? |
We have an application that use azure-sb ~0.11.1 which takes a dependency on azure-common. With a package.json of:
And an index.js file of:
You'll get: Cannot find module 'xmlbuilder/lib/XMLBuilder' |
Here's a simple reproduction:
|
Okay, got it. Let me see how to fix it and get back to ASAP. |
@freshlogic I have this PR #5182 to fix this issue. I pack a new azure-common package and change the azure-sb dependency into my local azure-common package path and then pack a new azure-sb package then change your package.json dependency into my local azure-sb package. Then I run |
This is PR is trying to fix issue #5159