Skip to content
This repository has been archived by the owner on May 5, 2023. It is now read-only.

try fix xml builder #5179

Merged
merged 4 commits into from
Jul 22, 2020
Merged

try fix xml builder #5179

merged 4 commits into from
Jul 22, 2020

Conversation

qiaozha
Copy link
Member

@qiaozha qiaozha commented Jul 16, 2020

This is PR is trying to fix issue #5159

@adxsdk6
Copy link
Collaborator

adxsdk6 commented Jul 16, 2020

Can one of the admins verify this patch?

@qiaozha
Copy link
Member Author

qiaozha commented Jul 20, 2020

@ramya-rao-a Can you help review my PR, Thanks. I have an email thread discuss about the background.

@ramya-rao-a ramya-rao-a requested a review from joheredi July 21, 2020 06:48
@ramya-rao-a
Copy link
Contributor

@joheredi Please review the changes here on updating the version of xml builder package being used

Copy link
Member

@joheredi joheredi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change looks good and all tests seem to be passing

@qiaozha qiaozha merged commit 2528f6d into master Jul 22, 2020
@qiaozha qiaozha deleted the try-fix-xmlbuilder branch July 22, 2020 01:13
@freshlogic
Copy link

v0.9.23 published to NPM an hour ago introduces: Cannot find module 'xmlbuilder/lib/XMLBuilder'

@qiaozha
Copy link
Member Author

qiaozha commented Jul 22, 2020

v0.9.23 published to NPM an hour ago introduces: Cannot find module 'xmlbuilder/lib/XMLBuilder'

Can you point out to me Where do you get this?

@freshlogic
Copy link

freshlogic commented Jul 22, 2020

We have an application that use azure-sb ~0.11.1 which takes a dependency on azure-common.

With a package.json of:

"dependencies": {
        "azure-sb": "~0.11.1"
}

And an index.js file of:

const azure = require('azure-sb');

You'll get: Cannot find module 'xmlbuilder/lib/XMLBuilder'

@freshlogic
Copy link

Here's a simple reproduction:

azure.zip

npm i
node index.js

internal/modules/cjs/loader.js:1068
  throw err;
  ^

Error: Cannot find module 'xmlbuilder/lib/XMLBuilder'

@qiaozha
Copy link
Member Author

qiaozha commented Jul 22, 2020

Okay, got it. Let me see how to fix it and get back to ASAP.

@qiaozha
Copy link
Member Author

qiaozha commented Jul 22, 2020

@freshlogic I have this PR #5182 to fix this issue. I pack a new azure-common package and change the azure-sb dependency into my local azure-common package path and then pack a new azure-sb package then change your package.json dependency into my local azure-sb package. Then I run node index.js it works. Can you help to double confirm.

@joheredi joheredi mentioned this pull request Jul 22, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants