Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add LOCM #191

Merged
merged 86 commits into from
May 26, 2023
Merged

Add LOCM #191

merged 86 commits into from
May 26, 2023

Conversation

e-cal
Copy link
Collaborator

@e-cal e-cal commented Apr 17, 2023 •
edited
Loading

Coverage Badge

  • LOCM model acquisition technique
  • LOCM test suite
  • supporting API changes
    • add ActionObservation
    • add support for lifted action models + output to PDDL

f1lth and others added 30 commits February 2, 2023 13:38
locm test
ffa7504
action obvservation added
0aebd4d
@e-cal
Added template locm extract file
99329cb
@e-cal
Fix imports
1708866
@e-cal
[wip] phase1 + testing
9e96afb
@e-cal
Rename ObservationLists ObservedTraceList
b6935f9
@e-cal
Add test for LOCM phase 1
d832dd8
@e-cal
Add return and 1 index action object pos
7948371
@e-cal
Complete example trace
a987d4e
@e-cal
Remove duplicate actions
7a7488f
@e-cal
Hash OS by AP only
6bed523
@e-cal
Rename OS APState
3c58aa3
@e-cal
Remove obj from APState, make start and end ints
9c4101d
@e-cal
Rewrite LOCM phase1 matching paper line for line
ff76305
merged from ecal main
018f7d6
@e-cal
Phase1 output dict with obj keys instead of set of just values
999ea27
phase2
6a6a065
@e-cal
Phase1 output dict with obj keys instead of set of just values
ab42631
@e-cal
Function for assumption 2
98f565b
@e-cal
Clean up formatting
d474c5b
@e-cal
Complete LOCM._get_sorts() (assumtion 2)
87c524f
@e-cal
Return sorts as dict
9cde494
@e-cal
Start adding recursive unify
f28397f
@e-cal
Use optional type for action params
ea88441
@e-cal
Working phase 1 (for first obj; todo: loop)
0a6d0ec
@e-cal
Complete phase 1
4c823d6
@e-cal
Move obs_tracelist len restriction to class init
6bd0e42
@e-cal
Complete state machine viz
1fab6dc
@e-cal
Reorder functions
b140d52
@e-cal
Comments
cd801de
@e-cal e-cal requested a review from haz April 17, 2023 19:57
haz
haz requested changes Apr 20, 2023
View reviewed changes
Copy link
Contributor

@haz haz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few minor questions. Seems to be mainly a refactor on ObservationTraceList stuff, and the core LOCM. We'll stress-test how well that code works as we put together the tutorial.

@haz
Copy link
Contributor

haz commented May 24, 2023

@e-cal @f1lth : We need some movement on the above things ASAP. Hoping to merge, toy around, then include this in the upcoming tutorial. Thanks!

@e-cal
Copy link
Collaborator Author

e-cal commented May 26, 2023

Addressed them all. Let me know if there's anything else!

@haz haz merged commit 7323b14 into AI-Planning:main May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haz haz haz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@e-cal @haz