Skip to content

feat: support generate model via sail #36

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

WataruNishimura
Copy link
Contributor

@WataruNishimura WataruNishimura commented May 22, 2024

Summary

  • Introduce the sail option and execute the generate model command via sail.

Detail

  • If the sail flag is enabled, php artisan will be replaced with sail artisan.
  • Error handling relies on Sail or npm. Laravel-typegen executes only the sail command.

Usage

npm run laravel-typegen --sail

Concerns

sail is executed by ./vendor/bin/sail now. If a breaking change in Sail occurs, it may not work.

relative issue

#27

@7nohe
Copy link
Owner

7nohe commented May 25, 2024

@WataruNishimura Thank you for creating the pull request. The code looks good, but we recently made changes to generate.ts to make it work without a PHP runtime, which has caused a conflict. Could you please resolve this conflict?

@WataruNishimura
Copy link
Contributor Author

@7nohe Sure! I'll try to do it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants