diff options
| author | Marc Mutz <marc.mutz@qt.io> | 2022-12-16 22:22:20 +0100 |
|---|---|---|
| committer | Volker Hilsheimer <volker.hilsheimer@qt.io> | 2022-12-20 14:25:08 +0000 |
| commit | 1f6fe8378a69494fa0817de4a53d66f2bd3eedbb (patch) | |
| tree | 3fdf8195e4ac998041d79ff288dc74b50337d3c6 | |
| parent | 47e409ffa7e5b767e814b1e3b281da8827e6a21d (diff) | |
[editorial] QUIP-6: number the rows in the table
This allows easier reference from reviews: "eh, that's SiC type B.1",
"no, it's A.1, because we QT_REMOVED_SINCE the old overload".
Change-Id: Ie23357e18d76900c1ba1631861780bccf9035bae
Reviewed-by: hjk <hjk@qt.io>
Reviewed-by: Ulf Hermann <ulf.hermann@qt.io>
Reviewed-by: Volker Hilsheimer <volker.hilsheimer@qt.io>
| -rw-r--r-- | quip-0006.rst | 46 |
1 files changed, 23 insertions, 23 deletions
diff --git a/quip-0006.rst b/quip-0006.rst index 7362b26..db35adb 100644 --- a/quip-0006.rst +++ b/quip-0006.rst @@ -53,29 +53,29 @@ Examples This list is not exhaustive. Issues not listed here should be discussed on the mailing-list and then added here. -+-------------------------------------------------------------+-------+--------+ -| | Classification | -| Source-incompatible Change +-------+--------+ -| | Cat A | Cat B | -+-------------------------------------------------------------+-------+--------+ -| Adding an overload of a function | X | | -+-+-----------------------------------------------------------+-------+--------+ -| | Exception: when causing ambiguities | | X | -+-+-----------------------------------------------------------+-------+--------+ -| Adding Q_OBJECT to a QObject subclass that lacks it. | X | | -+-------------------------------------------------------------+-------+--------+ -| Deprecating a function/class/typedef (even though it breaks | X | | -| -Werror=deprecated builds) | | | -+-------------------------------------------------------------+-------+--------+ -| Removing an include from a public header file | X | | -+-------------------------------------------------------------+-------+--------+ -| Removing top-level const from return types (see footnote 1) | X | | -+-------------------------------------------------------------+-------+--------+ -| Removing/restricting public API (even if binary-compatible) | | X | -+-+-----------------------------------------------------------+-------+--------+ -| | Exception: when preventing API misuses at compile-time, | X | | -| | e.g. when constraining templates (further). | | | -+-+-----------------------------------------------------------+-------+--------+ ++-------+-------------------------------------------------------------+-------+--------+ +| | | Classification | +| # | Source-incompatible Change +-------+--------+ +| | | Cat A | Cat B | ++-------+-------------------------------------------------------------+-------+--------+ +| A.1 | Adding an overload of a function | X | | ++-------+-+-----------------------------------------------------------+-------+--------+ +| B.1 | | Exception: when causing ambiguities | | X | ++-------+-+-----------------------------------------------------------+-------+--------+ +| A.2 | Adding Q_OBJECT to a QObject subclass that lacks it. | X | | ++-------+-------------------------------------------------------------+-------+--------+ +| A.3 | Deprecating a function/class/typedef (even though it breaks | X | | +| | -Werror=deprecated builds) | | | ++-------+-------------------------------------------------------------+-------+--------+ +| A.4 | Removing an include from a public header file | X | | ++-------+-------------------------------------------------------------+-------+--------+ +| A.5 | Removing top-level const from return types (see footnote 1) | X | | ++-------+-------------------------------------------------------------+-------+--------+ +| B.6 | Removing/restricting public API (even if binary-compatible) | | X | ++-------+-+-----------------------------------------------------------+-------+--------+ +| A.6 | | Exception: when preventing API misuses at compile-time, | X | | +| | | e.g. when constraining templates (further). | | | ++-------+-+-----------------------------------------------------------+-------+--------+ ยน On compilers, such as MSVC, that mangle the return type, this is a BiC change if the function is exported. In this case, the const needs to be kept for these |