Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Keycloak capitalization #8200

Open
wants to merge 1 commit into
base: 4.12.0
Choose a base branch
from

Conversation

ahus1
Copy link

@ahus1 ahus1 commented Feb 18, 2025

Description

Documentation compilation

  • Verified that documentation compiles without warnings.

(I'll rely on GitHub actions to perform that test)

Changelog

  • Updated CHANGELOG.md.

(I wouldn't add this to the changelog, please let me know if this isn't the case)

Code formatting & web optimization

  • Added or updated meta descriptions.
  • Updated redirects.js if necessary (guide).
  • Used three-space indentation in .rst files.

(not changed)

Writing style

  • Used bold for UI elements, italics for key terms or emphasis, and code font for Bash commands, file names, REST paths, and code.
  • Followed present tense, active voice, and a semi-formal tone.
  • Wrote short, clear, and concise sentences.

(not changed)

@ahus1 ahus1 marked this pull request as ready for review February 18, 2025 17:27
@ahus1
Copy link
Author

ahus1 commented Feb 18, 2025

About "Verified that documentation compiles without warnings." - I didn't see any automation in GitHub actions run here, so I just assume those minimal changes are ok.

@ahus1 ahus1 changed the base branch from main to 4.12.0 February 18, 2025 17:29
@ahus1 ahus1 force-pushed the is-fix-keycloak-capitalization branch from 703d04c to d8b488d Compare February 18, 2025 17:32
@ahus1 ahus1 changed the base branch from 4.12.0 to 4.11.1 February 18, 2025 17:32
@ahus1 ahus1 force-pushed the is-fix-keycloak-capitalization branch from d8b488d to 26addcf Compare February 18, 2025 17:33
@ahus1 ahus1 force-pushed the is-fix-keycloak-capitalization branch from 26addcf to d808908 Compare February 18, 2025 17:35
@ahus1 ahus1 changed the base branch from 4.11.1 to 4.12.0 February 18, 2025 17:36
@ahus1
Copy link
Author

ahus1 commented Feb 18, 2025

I've now updated the PR to target 4.12.0, but from reading the CONTRIBUTING.md file I don't really know which branch to choose. Please advise.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant