Update to mobx 6.13.6 #7488
Closed
Update to mobx 6.13.6 #7488
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjonsson
force-pushed
the
update-mobx
branch
3 times, most recently
from
d2b1b01 to
db94ccd
Compare
This was restricted in TerriaJS#7315 because mobx 6.13 started using Iterator helper types introduced in TypeScript 5.6.
pjonsson
force-pushed
the
update-mobx
branch
from
db94ccd to
4da2c93
Compare
pjonsson
commented
Feb 27, 2025
| @@ -1,6 +1,9 @@ | |||
| { | |||
| "compilerOptions": { | |||
| "target": "es2019", | |||
| // Use ES2024.collection, otherwise mobx 6.13 fails with: | |||
There was a problem hiding this comment.
The mobx tickets suggest to set skipLibCheck to true, but I'm not convinced that less static checking is what we want. The tickets for this issue are from mid-2024, so as second option they suggest setting lib to ESNext since that was the only place for ReadonlySetLike at the time.
Since ReadonlySetLike is also present in ES2024.collection now, I opted for that, and kept ES2019 for the rest. For some reason StoryBody.tsx failed to compile then because of a missing iterator in some HTMLCollection, so added DOM.Iterable to fix that.
|
This breaks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does
Depends on: #7485
This was restricted in #7315
because mobx 6.13 started using
Iterator helper types introduced
in TypeScript 5.6.
Test me
I believe this is tested by CI.
Checklist
doc/.