Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add calendars to schedule EVU, hot water block and reduced temperature #48

Open
wants to merge 25 commits into
base: main
Choose a base branch
from
Open

Add calendars to schedule EVU, hot water block and reduced temperature #48

wants to merge 25 commits into from

Conversation

hashtagKnorke
Copy link

@hashtagKnorke hashtagKnorke commented Dec 19, 2024 •
edited
Loading

the additions provide APIs to set a certain schedule

tested on an

"profile": {
        "icon": 2,
        "id": 1005,
        "name": "IQ",
        "thermiaName": "iTec"
    }

@hashtagKnorke
Merge pull request #1 from klejejs/main
19e7752 
incoming change from upstream
@hashtagKnorke
generically handle error response codes
30e65a4
@hashtagKnorke
add calendar function IDs
2f75c46
@hashtagKnorke
add schedule type for the request/response model of calendar schedule…
fee5470 
…s endpoints
@hashtagKnorke
add function for adding new schedule
f86bac3
@hashtagKnorke
add methods to retrieve and add schedules for heat pump installation
3df5d21
@hashtagKnorke
handling for heatpump timezone being different than client timezone
83c7876
@hashtagKnorke
add delete_schedule method to remove schedules from heat pump install…
c3386c2 
…ation
@hashtagKnorke
add pytz dependency for timezone handling
d0ac96a
@hashtagKnorke
add demo for functionality to retrieve, create, and delete schedules …
476c937 
…for heat pump
@hashtagKnorke
update condition for test schedule creation to use CHANGE_HEAT_PUMP_D…
c2aaaa5 
…ATA_DURING_TEST flag
@hashtagKnorke
update README to include schedule management functions and examples f…
5773dcf 
…or heat pump
@hashtagKnorke
update README to clarify parameters for create_schedule function and …
9289067 
…reference separate section
@hashtagKnorke
fix typo in create_schedule function description in README
095cc7f
klejejs
klejejs requested changes Dec 23, 2024
View reviewed changes
Copy link
Owner

@klejejs klejejs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for attempting to add the calendar feature to the API. Overall, it looks good, however, I added some comments for improvements.
Also, please run the linter black ThermiaOnlineAPI/ to lint the changes and it would be nice to look into adding some tests for this as well.

@hashtagKnorke
update pytz version requirement to 2023.3 in requirements.txt
9c8e44a
@hashtagKnorke
add JSON files to .gitignore for REST API example files in local debu…
b32c3da 
…gging
@hashtagKnorke
refactored mapping of Windows time zone names to pytz time zones into…
88ff514 
… separate file
@hashtagKnorke
renamed Schedule to CalendarSchedule class and remove legacy Schedule…
5536e2f 
… class

- introduce getters and make properties private
@hashtagKnorke
add detailed module docstring for ThermiaOnlineAPI constants
fad69c9
@hashtagKnorke
add CalendarFunction class with properties and JSON deserialization
a05a75f
@hashtagKnorke
refactor ThermiaAPI:
083aa69 
- function order re-sorted
- add get_supported_calendar_functions method
@hashtagKnorke
refactor ThermiaHeatPump to integrate CalendarFunction and CalendarSc…
47632de 
…hedule, updating methods for calendar functionality
@hashtagKnorke
update example.py to use CalendarSchedule instead of Schedule and dis…
6f79b85 
…play supported calendar functions
hashtagKnorke
hashtagKnorke commented Dec 26, 2024
View reviewed changes
Copy link
Author

@hashtagKnorke hashtagKnorke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

all comments should now be resolved or justified in conversation

@hashtagKnorke hashtagKnorke mentioned this pull request Dec 29, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@klejejs klejejs Awaiting requested review from klejejs

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hashtagKnorke @klejejs