Rollout default_max_pods_per_node to all #439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ChandranshuRao14
requested review from
adrienthebo,
Jberlinsky and
morgante
as code owners
morgante
suggested changes
Feb 19, 2020
There was a problem hiding this comment.
Looks like the max_pods_per_node setting on node pools is still only in the beta provider: GoogleCloudPlatform/magic-modules#2429 (comment)
Let's hold on this until that is fixed.
morgante
suggested changes
Feb 21, 2020
morgante
suggested changes
Feb 21, 2020
bharathkkb
approved these changes
Feb 22, 2020
morgante
approved these changes
Feb 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #435
Beta flag removed to allow changes to
default_max_pods_per_nodeAdded test for expected max pods