Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(reporter): --silent=passed-only to log failed tasks only #7530

Merged
merged 2 commits into from
Mar 17, 2025

Conversation

AriPerkkio
Copy link
Member

@AriPerkkio AriPerkkio commented Feb 20, 2025

Description

Adds --silent=passed-only that can be used to print logs from failing tests only.

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. If the feature is substantial or introduces breaking changes without a discussion, PR might be closed.
  • Ideally, include a test that fails without this PR but passes with it.
  • Please, don't make changes to pnpm-lock.yaml unless you introduce a new test example.

Tests

  • Run the tests with pnpm test:ci.

Documentation

  • If you introduce new functionality, document it. You can run documentation with pnpm run docs command.

Changesets

  • Changes in changelog are generated from PR name. Please, make sure that it explains your changes in an understandable manner. Please, prefix changeset messages with feat:, fix:, perf:, docs:, or chore:.

Copy link

netlify bot commented Feb 20, 2025

Deploy Preview for vitest-dev ready!

Built without sensitive environment variables

Name Link
🔨 Latest commit ffeef20
🔍 Latest deploy log https://app.netlify.com/sites/vitest-dev/deploys/67bd809a309d340008dd463f
😎 Deploy Preview https://deploy-preview-7530--vitest-dev.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@AriPerkkio AriPerkkio force-pushed the feat/silent-passed-only branch 2 times, most recently from a70b208 to 797ade9 Compare February 25, 2025 08:11
@AriPerkkio AriPerkkio force-pushed the feat/silent-passed-only branch from 797ade9 to ffeef20 Compare February 25, 2025 08:34
@AriPerkkio AriPerkkio marked this pull request as ready for review February 25, 2025 08:47
@AriPerkkio AriPerkkio requested review from hi-ogawa and sheremet-va and removed request for hi-ogawa February 25, 2025 08:57
@AriPerkkio AriPerkkio added this to the 3.1.0 milestone Feb 25, 2025
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was wondering how you would know whether it's success or failing when logging, but I realized it's buffering till the end --silent=passed-only. Obviously this is the only way, so just note for myself. 😃

@AriPerkkio AriPerkkio requested a review from hi-ogawa February 26, 2025 07:37
Copy link
Contributor

@hi-ogawa hi-ogawa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@tony
Copy link

tony commented Mar 12, 2025

Thank you @AriPerkkio! Feel free to rebase if you wish.

@hi-ogawa @sheremet-va Would this be viable to make it in for vitest 3.1?

@sheremet-va sheremet-va merged commit f9e1cb4 into vitest-dev:main Mar 17, 2025
13 checks passed
@AriPerkkio AriPerkkio deleted the feat/silent-passed-only branch March 17, 2025 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Only print captured console.* if a test fails.
4 participants