-
-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disabling card generation in social plugin does not work #7774
Comments
Thanks for reporting! Fixed in a7dc57c. |
Does the Social plugin do anything else apart of creating the cards? I think this option is also not used in the Insiders version at all. |
Not yet, but there are some things that might matter, e.g., allowing to set a custom image for all pages or specific pages only, not creating cards at all, but still adding the respective meta tags, etc. Currently both settings have the same functionality, but keeping a dedicated setting keeps it future-proof. |
Released as part of 9.5.48. |
Thank you for the quick release, @squidfunk! However, I'm not sure I understand this option, because I indeed expected it to be something like "not creating cards at all, but still adding the respective meta tags", but it appears that specifying |
Yes, that's correct. As said, currently, the social plugin only focuses on generating cards, so if no cards are generated, there are no meta tags to add. We might add an option in the future to add custom images, but that's currently not a priority. |
Context
As described in documentation specifying
cards: false
inmkdocs.yml
should "enable or disable social card generation".Bug description
Specifying
cards: false
inmkdocs.yml
the cards are still generated. Specifyingenabled: false
disables the whole social plugin, but this is a different option and doesn't satisfy the same needs as only disabling card generation.Related links
Reproduction
9.5.47-disabling-card-generation-in-social-plugin-does-not-work.zip
Steps to reproduce
mkdocs serve
pip install "mkdocs-material[imaging]
as instructed in terminalmkdocs serve
againhttp://127.0.0.1:8000/assets/images/social/index.png
.cache/plugin/social
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: