Skip to content

Commit 7fef050

Browse files
RafaelGSSrichardlau
authored andcommitted
build: build ICU with ICU_NO_USER_DATA_OVERRIDE
Backport-PR-URL: nodejs-private/node-private#378 CVE-ID: CVE-2023-23920 PR-URL: nodejs-private/node-private#374 Refs: https://hackerone.com/bugs?subject=nodejs&report_id=1625036 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com>
1 parent d80e831 commit 7fef050

File tree

1 file changed

+3
-0
lines changed

1 file changed

+3
-0
lines changed

Diff for: configure.py

+3
Original file line numberDiff line numberDiff line change
@@ -1653,6 +1653,9 @@ def icu_download(path):
16531653
# always set icu_small, node.gyp depends on it being defined.
16541654
o['variables']['icu_small'] = b(False)
16551655

1656+
# prevent data override
1657+
o['defines'] += ['ICU_NO_USER_DATA_OVERRIDE']
1658+
16561659
with_intl = options.with_intl
16571660
with_icu_source = options.with_icu_source
16581661
have_icu_path = bool(options.with_icu_path)

0 commit comments

Comments
 (0)