Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable the iofs adapter to also return other interfaces from io/fs #102

Merged
merged 1 commit into from
Jan 10, 2025

Conversation

JAORMX
Copy link

@JAORMX JAORMX commented Jan 10, 2025

Instead of relying on difficult casting, this improves developer
experience by providing easy ways of convering a billy filesystem into
the rest of the filesystem interfaces that are available in io/fs.

This is a safe operation since we already ensure the type implements
such interfaces some lines below my changes.

Instead of relying on difficult casting, this improves developer
experience by providing easy ways of convering a billy filesystem into
the rest of the filesystem interfaces that are available in `io/fs`.

This is a safe operation since we already ensure the type implements
such interfaces some lines below my changes.

Signed-off-by: Juan Antonio Osorio <ozz@stacklok.com>
Copy link
Member

@pjbgf pjbgf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pjbgf pjbgf merged commit 0009381 into go-git:releases/v5.x Jan 10, 2025
@JAORMX JAORMX deleted the iofs-extra-interfaces-v5 branch January 10, 2025 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants