-
Notifications
You must be signed in to change notification settings - Fork 923
Update CI node.js versions to 20.x #8055
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 453d4f4 The changes in this PR will be included in the next version bump. This PR includes changesets to release 0 packagesWhen changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Size Report 1Affected Products
Test Logs |
Size Analysis Report 1Affected Products
Test Logs |
Changeset File Check
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this expected to be empty?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think our changeset checker fails on finding no changeset file, which it shouldn't. But this PR doesn't need a changeset because it only affects tests and workflows.
Discussion
Upgrade our CI scripts and workflows to work in Node 20.x.
node
treatlocalhost
differently depending on the executing OS. For instance,localhost
might resolve to the IPv6 address::1
, but that's not the address that the emulators bind to.packages/rules-unit-testing/functions/package.json
engines
directive to define>=16
instead of requiring16
explicitly.Testing
CI
on: push:
triggers.getTestTasks
function inscripts/ci-test/tasks.ts
to always return the full lists of tests to run. This ensured that all tests were being executed by thetest-changed
workflows.API Changes
N/A.