Skip to content

Update CI node.js versions to 20.x #8055

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 22 commits into from
Mar 8, 2024
Merged

Update CI node.js versions to 20.x #8055

merged 22 commits into from
Mar 8, 2024

Conversation

DellaBitta
Copy link
Contributor

@DellaBitta DellaBitta commented Mar 5, 2024

Discussion

Upgrade our CI scripts and workflows to work in Node 20.x.

  • Updated workflows to use node 20.x across the board
  • Updated tests which use the emualtor to connect to '127.0.0.1' explicitly instead of 'localhost', since newer versions of node treat localhost differently depending on the executing OS. For instance, localhost might resolve to the IPv6 address ::1, but that's not the address that the emulators bind to.
  • Updated packages/rules-unit-testing/functions/package.json engines directive to define >=16 instead of requiring 16 explicitly.

Testing

CI

  • Tested E2E Smoke Tests via temporary on: push: triggers.
  • Temporarily mangled the getTestTasks function in scripts/ci-test/tasks.ts to always return the full lists of tests to run. This ensured that all tests were being executed by the test-changed workflows.
  • I have not tested the Staging and Release scripts, but as far as I know they don't have any nuiances (Such as the emulator configuration of the the Auth, Firestore and Function tests).

API Changes

N/A.

Copy link

changeset-bot bot commented Mar 5, 2024

🦋 Changeset detected

Latest commit: 453d4f4

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 0 packages

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 5, 2024

Size Report 1

Affected Products

  • @firebase/auth

    TypeBase (e60188d)Merge (bb6081e)Diff
    browser177 kB177 kB+38 B (+0.0%)
    esm5231 kB231 kB+38 B (+0.0%)
    module177 kB177 kB+38 B (+0.0%)
  • @firebase/auth/internal

    TypeBase (e60188d)Merge (bb6081e)Diff
    browser188 kB188 kB+38 B (+0.0%)
    esm5244 kB244 kB+38 B (+0.0%)
    module188 kB188 kB+38 B (+0.0%)
  • bundle

    TypeBase (e60188d)Merge (bb6081e)Diff
    auth (GoogleFBTwitterGitHubPopup)101 kB101 kB+19 B (+0.0%)
  • firebase

    TypeBase (e60188d)Merge (bb6081e)Diff
    firebase-auth.js147 kB147 kB+19 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/a1LDaLtrbL.html

@google-oss-bot
Copy link
Contributor

google-oss-bot commented Mar 5, 2024

Size Analysis Report 1

Affected Products

  • @firebase/auth

    • getAuth

      Size

      TypeBase (e60188d)Merge (bb6081e)Diff
      size72.4 kB72.4 kB+19 B (+0.0%)
      size-with-ext-deps100 kB100 kB+19 B (+0.0%)

Test Logs

  1. https://storage.googleapis.com/firebase-sdk-metric-reports/lHbYY53nc0.html

@firebase firebase deleted a comment from github-actions bot Mar 6, 2024
Copy link
Contributor

github-actions bot commented Mar 6, 2024

Changeset File Check ⚠️

  • Warning: This PR modifies files in the following packages but they have not been included in the changeset file:%0A - @firebase/auth%0A - @firebase/firestore%0A - @firebase/rules-unit-testing%0A%0A Make sure this was intentional.

@DellaBitta DellaBitta marked this pull request as ready for review March 7, 2024 14:36
@DellaBitta DellaBitta requested review from a team as code owners March 7, 2024 14:36
Copy link
Contributor

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this expected to be empty?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think our changeset checker fails on finding no changeset file, which it shouldn't. But this PR doesn't need a changeset because it only affects tests and workflows.

@DellaBitta DellaBitta merged commit feb5038 into master Mar 8, 2024
44 checks passed
@DellaBitta DellaBitta deleted the ddb-ci-node-20 branch March 8, 2024 13:31
@firebase firebase locked and limited conversation to collaborators Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants