[0.6] Scrub reports during aggregation job creation, rather than the initial aggregation step. #2559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
branlwyd
force-pushed
the
bran/0.6-agg-job-same-request
branch
2 times, most recently
from
99f9cc4 to
1e8c518
Compare
This is implemented by copying the necessary report information into the report aggregations at time of aggregation job creation. This means that client-report GC will not change the request that is made.
branlwyd
force-pushed
the
bran/0.6-agg-job-same-request
branch
from
1e8c518 to
35afcf0
Compare
…l aggregation step. Other than being the earliest point that we can scrub reports, this avoids (briefly) duplicating report data in both the `client_reports` and `report_aggregations` tables. I think placing this logic in the aggregation job creator also makes more sense for when we'll eventually expand it to handle VDAFs requiring multiple aggregations per report.
branlwyd
force-pushed
the
bran/0.6-scrub-reports
branch
from
1bab5f0 to
3139e87
Compare
|
(This is rebased & ready for review.) |
tgeoghegan
approved these changes
Jan 29, 2024
inahga
approved these changes
Jan 30, 2024
divergentdave
approved these changes
Jan 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Other than being the earliest point that we can scrub reports, this avoids (briefly) duplicating report data in both the
client_reportsandreport_aggregationstables. I think placing this logic in the aggregation job creator also makes more sense for when we'll eventually expand it to handle VDAFs requiring multiple aggregations per report.Backport of #2547. Stacked on #2556.