Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changes for Pyodide 0.26.4 #3253

Merged
merged 1 commit into from
Dec 18, 2024
Merged

Changes for Pyodide 0.26.4 #3253

merged 1 commit into from
Dec 18, 2024

Conversation

hoodmane
Copy link
Contributor

These are the changes to src/pyodide needed to use Pyodide 0.26.4.

@hoodmane hoodmane requested review from a team as code owners December 17, 2024 13:41
@hoodmane hoodmane force-pushed the hoodmane/workerd-changes-for-0.26.4 branch from a088cef to 11ab0ef Compare December 17, 2024 13:43
@hoodmane hoodmane force-pushed the hoodmane/workerd-changes-for-0.26.4 branch from 11ab0ef to 2b83bf7 Compare December 17, 2024 13:46
danlapid
danlapid approved these changes Dec 18, 2024
View reviewed changes
Copy link
Collaborator

@danlapid danlapid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hoodmane
Copy link
Contributor Author

Seems to be a real windows failure though:

ERROR: D:/a/workerd/workerd/src/pyodide/BUILD.bazel:225:13: Transpiling & type-checking TypeScript project @//src/pyodide:pyodide@tsproject [tsc -p src/pyodide/tsconfig.json] failed: (Exit 1): tsc.bat failed: error executing TsProject command (from target //src/pyodide:pyodide@tsproject) 
error TS5055: Cannot write file 'C:/tmp/hs7imhxj/execroot/workerd/bazel-out/x64_windows-opt/bin/src/pyodide/internal/pool/esbuild.config.mjs' because it would overwrite input file.

@hoodmane
Copy link
Contributor Author

I don't understand how this could cause it though...

@hoodmane hoodmane merged commit 0033829 into main Dec 18, 2024
15 checks passed
@hoodmane hoodmane deleted the hoodmane/workerd-changes-for-0.26.4 branch December 18, 2024 11:52
@hoodmane
Copy link
Contributor Author

Nevermind just a flake.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danlapid danlapid danlapid approved these changes

@a-robinson a-robinson Awaiting requested review from a-robinson a-robinson is a code owner automatically assigned from cloudflare/workers-runtime-1

@jp4a50 jp4a50 Awaiting requested review from jp4a50 jp4a50 is a code owner automatically assigned from cloudflare/workers-runtime-1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoodmane @danlapid