Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cx-api: Missing readme from ff #33866

Closed
IkeNefcy opened this issue Mar 21, 2025 · 4 comments · Fixed by #33867
Closed

cx-api: Missing readme from ff #33866

IkeNefcy opened this issue Mar 21, 2025 · 4 comments · Fixed by #33867
Labels
@aws-cdk/cx-api Related to the Cloud Executable API documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged.

Comments

@IkeNefcy
Copy link
Contributor

Describe the issue

#33729 ff was added without a readme update in cx-api.

Links

https://github.com/aws/aws-cdk/blob/main/packages/aws-cdk-lib/cx-api/README.md
@IkeNefcy IkeNefcy added documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged. labels Mar 21, 2025
@IkeNefcy
Copy link
Contributor Author

doing up a pr real quick

@github-actions github-actions bot added the @aws-cdk/cx-api Related to the Cloud Executable API label Mar 21, 2025
@IkeNefcy IkeNefcy mentioned this issue Mar 21, 2025
Merged
1 task
@IkeNefcy
Copy link
Contributor Author

IkeNefcy commented Mar 21, 2025 •
edited
Loading

@moelasmar if you wanted to review. (Approver of ff)

@mergify mergify bot closed this as completed in #33867 Mar 21, 2025
@mergify mergify bot closed this as completed in 6761f56 Mar 21, 2025
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

1 similar comment
@github-actions GitHub Actions
Copy link

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 21, 2025
shikha372 pushed a commit to shikha372/aws-cdk that referenced this issue Apr 4, 2025
@IkeNefcy @shikha372
fix(cx-api): adding missing readme (aws#33867)
21c9340 
### Issue # 

Closes aws#33866


### Reason for this change

aws#33729 missing readme update for cx-api


### Description of changes

added readme

https://github.com/aws/aws-cdk/blob/eae1d4fcc500ed39973a2d796c161171894eeb41/packages/aws-cdk-lib/cx-api/README.md?plain=1#L662-L681


### Checklist
- [X] My code adheres to the [CONTRIBUTING GUIDE](https://github.com/aws/aws-cdk/blob/main/CONTRIBUTING.md) and [DESIGN GUIDELINES](https://github.com/aws/aws-cdk/blob/main/docs/DESIGN_GUIDELINES.md)

----

*By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license*
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
@aws-cdk/cx-api Related to the Cloud Executable API documentation This is a problem with documentation. needs-triage This issue or PR still needs to be triaged.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(cx-api): adding missing readme IkeNefcy/aws-cdk
1 participant
@IkeNefcy