feat(basic): prefer non global process object #214
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I've re-thought it carefully.
import.meta.env.PROD
. See https://vitejs.dev/guide/env-and-mode.html.new webpack.DefinePlugin({'import.meta.env.NODE_ENV': JSON.stringify(process.env.NODE_ENV)})
to inject it. See https://webpack.js.org/plugins/environment-plugin/Any way, we should not use
process.env
in frontend projects. So enable this rule will benefit node projects.BTW, why did not vite document mention the
process.env
butimport.meta.env
? Maybe vite author do not recommend us to useprocess.env
in frontend project. 😆Linked Issues
Additional context
#159