-
-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ts): ban cjs exports in ts file #167
Conversation
6e141ea
to
b5b8caa
Compare
It's ready to be reviewed. |
I am not sure if I'd like to take that complicity. Ideally, I would prefer to have it defined in a plugin and enable as a rule. |
It's better. I don't have to much experience on eslint plugin. I will look into it on weekends. |
ae79900
to
614534d
Compare
Hi @antfu. Refactored to plugin rules. Please take a review. |
7b5befa
to
a7a2e85
Compare
It's ready. |
Hi @antfu , can you review this PR? After merging this PR, this eslint-config preset will force user to use Let's make |
Description
Ban cjs exports in ts file.
Copy this content to test.
Linked Issues
Additional context