-
-
Notifications
You must be signed in to change notification settings - Fork 478
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: allow void as statement in ts file #142
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If I want to make my project stricter, I will add When fixing some |
zanminkian
force-pushed
the
zmj-no_void
branch
from
December 16, 2022 07:37
6bb3ff9
to
5da4357
Compare
MaloLebrin
referenced
this pull request
in MaloLebrin/naturopathe-camion-nuxt3
Jan 29, 2023
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Change | Age | Adoption | Passing | Confidence | |---|---|---|---|---|---| | [@antfu/eslint-config](https://togithub.com/antfu/eslint-config) | [`^0.34.0` -> `^0.35.0`](https://renovatebot.com/diffs/npm/@antfu%2feslint-config/0.34.0/0.35.1) | [![age](https://badges.renovateapi.com/packages/npm/@antfu%2feslint-config/0.35.1/age-slim)](https://docs.renovatebot.com/merge-confidence/) | [![adoption](https://badges.renovateapi.com/packages/npm/@antfu%2feslint-config/0.35.1/adoption-slim)](https://docs.renovatebot.com/merge-confidence/) | [![passing](https://badges.renovateapi.com/packages/npm/@antfu%2feslint-config/0.35.1/compatibility-slim/0.34.0)](https://docs.renovatebot.com/merge-confidence/) | [![confidence](https://badges.renovateapi.com/packages/npm/@antfu%2feslint-config/0.35.1/confidence-slim/0.34.0)](https://docs.renovatebot.com/merge-confidence/) | --- ### Release Notes <details> <summary>antfu/eslint-config</summary> ### [`v0.35.1`](https://togithub.com/antfu/eslint-config/releases/tag/v0.35.1) [Compare Source](https://togithub.com/antfu/eslint-config/compare/v0.35.0...v0.35.1) ##### 🐞 Bug Fixes - Disable `@typescript-eslint/no-unused-vars` - by [@​antfu](https://togithub.com/antfu) [<samp>(4b576)</samp>](https://togithub.com/antfu/eslint-config/commit/4b57638) ##### [View changes on GitHub](https://togithub.com/antfu/eslint-config/compare/v0.35.0...v0.35.1) ### [`v0.35.0`](https://togithub.com/antfu/eslint-config/releases/tag/v0.35.0) [Compare Source](https://togithub.com/antfu/eslint-config/compare/v0.34.2...v0.35.0) ##### 🚀 Features - Auto fix for unused imports - by [@​antfu](https://togithub.com/antfu) [<samp>(f466a)</samp>](https://togithub.com/antfu/eslint-config/commit/f466ac5) ##### [View changes on GitHub](https://togithub.com/antfu/eslint-config/compare/v0.34.2...v0.35.0) ### [`v0.34.2`](https://togithub.com/antfu/eslint-config/releases/tag/v0.34.2) [Compare Source](https://togithub.com/antfu/eslint-config/compare/v0.34.1...v0.34.2) ##### 🚀 Features - Allow require() in cjs - by [@​antfu](https://togithub.com/antfu) [<samp>(f45a0)</samp>](https://togithub.com/antfu/eslint-config/commit/f45a0d9) ##### 🐞 Bug Fixes - Group `&&`, ` - by ** ` and `?:` ([#​152](https://togithub.com/antfu/eslint-config/issues/152))\*\* [<samp>()</samp>](https://togithub.com/antfu/eslint-config/commit/) ##### [View changes on GitHub](https://togithub.com/antfu/eslint-config/compare/v0.34.1...v0.34.2) ### [`v0.34.1`](https://togithub.com/antfu/eslint-config/releases/tag/v0.34.1) [Compare Source](https://togithub.com/antfu/eslint-config/compare/v0.34.0...v0.34.1) ##### 🚀 Features - **ts**: Enable `jest/unbound-method` - by [@​zanminkian](https://togithub.com/zanminkian) in [https://github.com/antfu/eslint-config/issues/141](https://togithub.com/antfu/eslint-config/issues/141) [<samp>(2ad35)</samp>](https://togithub.com/antfu/eslint-config/commit/2ad3503) ##### 🐞 Bug Fixes - Allow void as statement in ts file - by [@​zanminkian](https://togithub.com/zanminkian) in [https://github.com/antfu/eslint-config/issues/142](https://togithub.com/antfu/eslint-config/issues/142) [<samp>(5d5b3)</samp>](https://togithub.com/antfu/eslint-config/commit/5d5b3c3) - Prefer const when all variables in destructuring should be const - by [@​sxzz](https://togithub.com/sxzz) in [https://github.com/antfu/eslint-config/issues/149](https://togithub.com/antfu/eslint-config/issues/149) [<samp>(2a224)</samp>](https://togithub.com/antfu/eslint-config/commit/2a224ef) ##### [View changes on GitHub](https://togithub.com/antfu/eslint-config/compare/v0.34.0...v0.34.1) </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://app.renovatebot.com/dashboard#github/MaloLebrin/naturopathe-camion-nuxt3). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNC4xMTYuMSIsInVwZGF0ZWRJblZlciI6IjM0LjExNi4xIn0=-->
byyuurin
added a commit
to byyuurin/eslint-config
that referenced
this pull request
Feb 28, 2023
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Let's say I have code above. Run lint will cause
no-void
error. But after addingtsconfig.eslint.json
file to project root, this error will disappear.I think, adding
tsconfig.eslint.json
file to the root of project should bring more stricter rules to project. Deleting thetsconfig.eslint.json
file should remove some stricter rules. But in the example above, deleting thetsconfig.eslint.json
file will bring more stricter rule, which should not be.Linked Issues
Additional context