Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix EnumTryAs to allow attributes on enum variant fields #400

Merged
merged 1 commit into from
Jan 12, 2025
Merged

fix EnumTryAs to allow attributes on enum variant fields #400

merged 1 commit into from
Jan 12, 2025

Conversation

phsym
Copy link
Contributor

@phsym phsym commented Jan 3, 2025

Closes #399

@phsym
fix EnumTryAs to allow attributes on enum variant fields
1659717 
Closes Peternator7#399

Signed-off-by: Pierre-Henri Symoneaux <pierre-henri.symoneaux@ovhcloud.com>
@Peternator7 Peternator7 merged commit 96fa148 into Peternator7:master Jan 12, 2025
1 check failed
@phsym
Copy link
Contributor Author

phsym commented Jan 13, 2025

@Peternator7 thanks for accepting the PR. Any chance to get a release including this fix soon ?

@phsym
Copy link
Contributor Author

phsym commented Jan 13, 2025

For information, I need that to use strum in combination with serde_with and more specifically with serde_as attribute as documented in https://docs.rs/serde_with/latest/serde_with/#advanced-serde_as-usage

@Peternator7
Copy link
Owner

Just included this in 0.27. Thanks for the fix and your patience :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deriving EnumTryAs on an enum with field attributes produces unparsable tokens
2 participants
@phsym @Peternator7