Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release windows binaries as .zip files #808

Closed
SpexGuy opened this issue Dec 5, 2022 · 6 comments
Closed

Release windows binaries as .zip files #808

SpexGuy opened this issue Dec 5, 2022 · 6 comments
Labels
enhancement New feature or request

Comments

@SpexGuy
Copy link

SpexGuy commented Dec 5, 2022

zst is not a format that most windows users can decompress easily. Even 7zip, afaict the most widely installed third party decompression tool on windows, can't open them. For the windows binaries in releases to be useful, they should be released in a format that windows users can use. Preferably .zip, which can be decompressed directly from the OS's file explorer.

The zstd project does have windows executables in its releases, but it's a bit silly IMO to require users to download this oddly specific project to use ZLS.

@SpexGuy SpexGuy added the enhancement New feature or request label Dec 5, 2022
@llogick
Copy link
Contributor

llogick commented Dec 5, 2022

Ditto for PR builds (and having an artifact per arch). Example and the result (Do note that the artifact size listed is "as produced", the downloaded file ends up being much smaller).

@SuperAuguste
Copy link
Member

Feel free to PR this change :)

@llogick
Copy link
Contributor

llogick commented Dec 6, 2022

Feel free to PR this change :)

Only if you're sure that doing away with the .tar.zst files doesn't affect anything on the remote host in the "Beam to Felix" step.

@SuperAuguste
Copy link
Member

SuperAuguste commented Dec 6, 2022

We don't use any of the compressed archives we send to Felix, instead opting to use the single executables, so yep it's all good.

@Techatrix
Copy link
Member

The 0.10.0 Release is shipping zstd compressed tarballs on all architectures.

@Techatrix Techatrix reopened this Jun 23, 2023
@Techatrix
Copy link
Member

duplicate of #407
the latest ZLS 0.11.0 release now ships .zip files for windows

@Techatrix Techatrix closed this as not planned Won't fix, can't repro, duplicate, stale Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants