Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: wokwi/avr8js
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v0.18.6
Choose a base ref
...
head repository: wokwi/avr8js
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v0.18.7
Choose a head ref
  • 2 commits
  • 3 files changed
  • 1 contributor

Commits on Dec 13, 2021

  1. fix(twi): fails on repeated start condition 

    reproduction: https://wokwi.com/arduino/projects/306115576172905024

minimal reproduction code:

```cpp
#include <Wire.h>

void setup() {
  Serial.begin(115200);
  Wire.begin();

  Wire.beginTransmission(0x68);
  Wire.write( 0x3B);
  Wire.endTransmission( false);  // <---- Fails after this

  auto n = Wire.requestFrom(0x68, 6);
  if (n == 6) {
    int16_t AcX = Wire.read() << 8 | Wire.read(); // 0x3B (ACCEL_XOUT_H) & 0x3C (ACCEL_XOUT_L)
    int16_t AcY = Wire.read() << 8 | Wire.read(); // 0x3D (ACCEL_YOUT_H) & 0x3E (ACCEL_YOUT_L)
    int16_t AcZ = Wire.read() << 8 | Wire.read(); // 0x3F (ACCEL_ZOUT_H) & 0x40 (ACCEL_ZOUT_L)
    Serial.print( "AcX = ");    Serial.print( AcX);
    Serial.print( " | AcY = "); Serial.print( AcY);
    Serial.print( " | AcZ = "); Serial.print( AcZ);
    Serial.println();
  } else {
    Serial.println( "--------- ERROR ---------");
  }
}

void loop() {}
```
    @urish
    urish committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    1d70883 View commit details
    Browse the repository at this point in the history

  2. 0.18.7

    @urish
    urish committed Dec 13, 2021
    Configuration menu
    Copy the full SHA
    8c1f76f View commit details
    Browse the repository at this point in the history
Loading