From 52d2647abbf5b692d32717932b8bd392197068e6 Mon Sep 17 00:00:00 2001 From: Li Kui <90845831+likui628@users.noreply.github.com> Date: Thu, 14 Jul 2022 23:36:07 +0800 Subject: [PATCH 1/3] fix: navbar menu may exceeds the screen closes #988 --- src/client/theme-default/components/VPMenu.vue | 2 ++ 1 file changed, 2 insertions(+) diff --git a/src/client/theme-default/components/VPMenu.vue b/src/client/theme-default/components/VPMenu.vue index 7dad2062d2ec..2b13899837f3 100644 --- a/src/client/theme-default/components/VPMenu.vue +++ b/src/client/theme-default/components/VPMenu.vue @@ -29,6 +29,8 @@ defineProps<{ background-color: var(--vp-c-bg); box-shadow: var(--vp-shadow-3); transition: background-color 0.5s; + max-height:calc(100vh - var(--vp-nav-height-desktop)); + overflow-y: scroll; } .dark .VPMenu { From a7c70c6d982b99d5d5254b97dad0feb580ce3c1c Mon Sep 17 00:00:00 2001 From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com> Date: Thu, 14 Jul 2022 22:52:39 +0530 Subject: [PATCH 2/3] fix: don't show scrollbar on menu flyouts if not necessary --- src/client/theme-default/components/VPMenu.vue | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/client/theme-default/components/VPMenu.vue b/src/client/theme-default/components/VPMenu.vue index 2b13899837f3..f47fa310260d 100644 --- a/src/client/theme-default/components/VPMenu.vue +++ b/src/client/theme-default/components/VPMenu.vue @@ -30,7 +30,7 @@ defineProps<{ box-shadow: var(--vp-shadow-3); transition: background-color 0.5s; max-height:calc(100vh - var(--vp-nav-height-desktop)); - overflow-y: scroll; + overflow-y: auto; } .dark .VPMenu { From e52df97448408af040d9f1ad9a1d147a2cf9ce2e Mon Sep 17 00:00:00 2001 From: Divyansh Singh <40380293+brc-dd@users.noreply.github.com> Date: Fri, 15 Jul 2022 11:51:04 +0530 Subject: [PATCH 3/3] chore: tweak styles --- src/client/theme-default/components/VPMenu.vue | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/src/client/theme-default/components/VPMenu.vue b/src/client/theme-default/components/VPMenu.vue index f47fa310260d..15249aca44f6 100644 --- a/src/client/theme-default/components/VPMenu.vue +++ b/src/client/theme-default/components/VPMenu.vue @@ -29,10 +29,16 @@ defineProps<{ background-color: var(--vp-c-bg); box-shadow: var(--vp-shadow-3); transition: background-color 0.5s; - max-height:calc(100vh - var(--vp-nav-height-desktop)); + max-height: calc(100vh - var(--vp-nav-height-mobile)); overflow-y: auto; } +@media (min-width: 960px) { + .VPMenu { + max-height: calc(100vh - var(--vp-nav-height-desktop)); + } +} + .dark .VPMenu { box-shadow: var(--vp-shadow-2); }