Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(theme): unresponsive back button with empty input in search box #2566

Merged
merged 1 commit into from Jul 2, 2023
Merged

fix(theme): unresponsive back button with empty input in search box #2566

merged 1 commit into from Jul 2, 2023

Conversation

quadratz
Copy link
Contributor

@quadratz quadratz commented Jul 2, 2023

Steps to Reproduce:

  1. Navigate to the page with the local search functionality (not Algolia).
  2. Make sure the screen size is small or use a mobile phone.
  3. Click on the search box to open it.
  4. Without entering any text, click the back button.
  5. Observe that the search box does not close.

@brc-dd brc-dd changed the title fix(client): unresponsive back button with empty input in search box fix(theme): unresponsive back button with empty input in search box Jul 2, 2023
@brc-dd brc-dd merged commit fa3780f into vuejs:main Jul 2, 2023
@quadratz quadratz deleted the close-search branch July 2, 2023 09:11
@quadratz quadratz mentioned this pull request Jul 2, 2023
9 tasks
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants